Review XArray implementation in easyCore

EasyScience / EasyDiffractionApp

Diffraction data analysis application

https://easydiffraction.org

BSD 3-Clause "New" or "Revised" License

4 stars 1 forks source link

Open rozyczko opened 3 years ago

rozyczko commented 3 years ago

First step in the TOF plan

rozyczko commented 2 years ago

Looked at develop 65ce490

easyCore\Datasets\xarray.py

two main classes:

easyCoreDatasetAccessor
easyCoreDataarrayAccessor
- core_object seems to be redundant. is it just a holder for metadata? if so, why use weakref?
- add/remove_coordinate/variable - switching to scipp will make this redundant, since scipp has units and errors built in
- why removing weights in fitting? (l. 423) in dataset but retain them for dataarray? (l.692)