EasyScience / EasyDiffractionApp

Diffraction data analysis application
https://easydiffraction.org
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Default phase fix #242

Closed rozyczko closed 1 year ago

rozyczko commented 1 year ago

This fixes the issue of ephemeric failure of loading a phase into EDA, visible on GH hosts and occasionally locally.

periodictable dependency requires data files in specific place. This is being used on every structure load and I've no idea why this wasn't happening earlier.

The standard way to specify missing data is to add the definitions to the project toml file. However, I couldn't find a way to query site-packages location in toml, so had to add some logic to the freeze script.

rozyczko commented 1 year ago

closing since these changes are part of the upcoming r0.8.5_fixes branch merge