search

EasyX-Community / easyNOMP

EasyNOMP - The easy NOMP mining pool - Minor development under way
https://pool.easyx.cc
GNU General Public License v2.0
56 stars 63 forks source link

Pool/Miner stats stop working #140

Closed mooleshacat closed 5 years ago

mooleshacat commented 5 years ago

When an invalid miner address makes it into the redis database, the miner stats and pool stats will stop working.

This is because when the browser is making the request to the API for live data, the API stumbles across an invalid address, and attempts to retrieve data for it - causing an exception, and halting the API response dead in it's tracks.

Short term fix is to just clear redis data with redis-cli FLUSHALL; unfortunately this clears all payment data.

Long term, this issue needs to be addressed. https://github.com/foxer666/node-open-mining-portal/issues/143 may fix it.

Solution is to validate every worker address that the API requests information for, and only request and return information for valid workers.

Also API data retrieval is very slow. This can be due to https://github.com/foxer666/node-open-mining-portal/issues/143 as well.

Lastly, I would ensure that JsonGet has some timeout set (even at 120 sec)

Duplicate issues: https://github.com/foxer666/node-open-mining-portal/issues/150 https://github.com/zone117x/node-open-mining-portal/issues/644 https://github.com/1301313Y/BootNOMP/issues/10

Samples: https://miningpool.easyx.info/stats/mogwaicoin (charts not loading) https://miningpool.easyx.info/api/pool_stats (only available until next FLUSHALL) Uploaded TXT file coming soon...

mooleshacat commented 5 years ago

Payment processor is first, this is second, adding algos is third for v1.1.4 - then it will be finalized just to get stability back in the repository since the initial forking.

If anyone wishes to fork this and work on this in the meantime, I would appreciate it :) Just be sure to submit a PR to get credited for work :)

mooleshacat commented 5 years ago

Related to issue https://github.com/foxer666/node-open-mining-portal/issues/106 (worker shares not being validated in payment processor OR api calls)

mooleshacat commented 5 years ago

Turns out this issue is causing charts to stop showing...

https://github.com/foxer666/node-open-mining-portal/issues/106 does not seem to fix it.

Raised priority, this creates a bad user experience.

mooleshacat commented 5 years ago

This affects pools for ALL coins, not just one. Also note, I have not yet even touched the API codes yet...

Moved to top of priority list, investigating now... Could use help, in murky waters...

With bugs like this, I am surprised NOMP even worked in the first place... I think I may not be from the days of NOMP, I think I am from the days of MPOS - before php-mpos namechange - I musta been really medicated :P

mooleshacat commented 5 years ago

Note to self: install redis tools to look at redis data, try to locate the data causing the crash, and remove it. This should restore charts and confirm the issue.

mooleshacat commented 5 years ago

redis-bug

Turns out I was wrong... But installing RedisMin has brought me closer to the issue.

When I access the "StatHistory" table, it gives an error "ESOCKETOVERFLOW" and the redis server restarts...

Reloading any page with graphs on it, and going back to RedisMin, gives the same error + restart.

Suspecting a corrupted table somehow?

Screenshot attached.

Ideas?

mooleshacat commented 5 years ago

Purging Redis data clears the issue, and at some point it comes back...

Solution: Need actual DB (MySQL/MariaDB) to operate properly (and with less memory)

Flushed RDB on EasyX Pool, charts back, miners back, redis tables / data back, and now I can view that table.

Will keep eye on RDB resume work on this issue when problem returns

mooleshacat commented 5 years ago

This could be due to the memory filling up (because we are using a memory cache like a database)

mooleshacat commented 5 years ago

redis-usage The above 14MB in memory is from a few hours of mining slowly... If we dump the hashrate we did before, I could see the memory of the server filling up easily. This is only with 4 miners. Imagine running an average sized pool with this...

Awaiting more testing data...

mooleshacat commented 5 years ago

https://github.com/leshacat/EasyNOMP/issues/140#issuecomment-435709754

More data: It just happened again. I can access all tables except the last one, statHistory. There must be invalid data causing a BOF when accessing it, because RedisMin can't even access it.

I will try to flush just that table and see what happens.

[UPDATE] redis-cli DEL statHistory and restarting pool clears the issue temporarily, but statistics data is lost.

More reason why we need MySQL

mooleshacat commented 5 years ago

Possible fix in config.json (under website):

"historicalRetention": 95040,

Set historicalRetention to 95040 or less. Testing now. Could be related to data storage (redis vs mysql)

mooleshacat commented 5 years ago

Ignore previous comment. It appears this is related to the redis server when accessing statsHistory table.

I suspect corrupted data is making it into the redis DB OR possibly table gets too large and redis gives up.

MySQL replacement (https://github.com/leshacat/EasyNOMP/issues/157) would probably fix this issue.

mooleshacat commented 5 years ago

moved to https://github.com/EasyX-Community/EasyNOMP/issues/27

mooleshacat commented 5 years ago

This bug is fixed.

The issue was that redis was outputting too much data (200MB+ if I recall correctly)