Patch 1

[Zerokami]

Features added: 1) IP and UserAgent logging 2) Admin with __str__ and @python2_unicode_compatible for easy navigation 3) Fixed sitemaps and changed priority to 0.5 4) Topic slug with dashes instead of underscores while maintaining backlink compatability (Doesn't break old underscore links) 5) Added metadata for SEO 6) IMPORTANT: Fixed failing builds. The build works and we won't have an ugly build-failing tag 7) Added redirect tests for Topic and no-slug Thread 8) Added tests for redirect of slug, old Topic(_) 9) Added test for Django 1.11

@EatEmAll We need to fix the ugly failing build tag in the main repo. Please accept this pull request. The failing builds are caused due to Django 2.0 being installed instead of 1.10 in your repo.

https://stackoverflow.com/a/16203978/8893667

Advanced moderation is next. Going to take inspiration from askbot, biostars etc

Added Admin and IP and User Agent Logging

Added MetaData

Admin needs to be fixed. A lot needs to be added. What's a django site without admin, right?

IPAddress is working. On my localhost it shows 127.0.0.1 and for UserAgent that works perfectly and undoubtedly.

IP address is doubtful. Needs to be tested live and with proxies to see if anychanges are required.

[codecov-io]

Codecov Report

Merging #18 into dev will increase coverage by 2.81%. The diff coverage is 85.52%.

@@            Coverage Diff             @@
##              dev      #18      +/-   ##
==========================================
+ Coverage   74.82%   77.63%   +2.81%     
==========================================
  Files          15       16       +1     
  Lines         556      617      +61     
  Branches       73       85      +12     
==========================================
+ Hits          416      479      +63     
+ Misses        109      105       -4     
- Partials       31       33       +2

Impacted Files	Coverage Δ
djeddit/urls.py	85.71% <ø> (ø)	:arrow_up:
djeddit/admin.py	100% <100%> (ø)	:arrow_up:
djeddit/sitemaps.py	77.77% <100%> (+77.77%)	:arrow_up:
djeddit/migrations/0005_auto_20171212_1229.py	100% <100%> (ø)
djeddit/views.py	75.45% <73.33%> (-0.24%)	:arrow_down:
djeddit/models.py	80.64% <89.28%> (+2.44%)	:arrow_up:
djeddit/templatetags/djeddit_tags.py	62.06% <0%> (+2.29%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6114b38...795b9a1. Read the comment docs.

[EatEmAll]

Thanks! I'm reviewing your changes right now.

[EatEmAll]

I made some changes & fixes for this pull request in this commit:

• removed redundant methods: Topic.urlTitleOld and Topic.get_absolute_url

• removed check in Topic.getTopic since urlTitle is expected to contain -instead of for spaces

• views.topicPage: removed _ check in topic_title // this is handles in Topic.getTopic

• removed tests TopicPageTest.testRedirectsOld, ThreadPageTest.testRedirectsOld

• removed Thread.get_absolute_url

• added method Post.setMeta // updates ip & user_agent

• TopicModelTest.testGetTopic: testing wrong title // fixed

• CreateThreadTest._testSubmit, ReplyPostTest.testSubmit: test Post.setMeta method views.py:

• createThread, replyPost: use Post.setMeta to avoid repeating code

• threadPage: removed http redirection

[Zerokami]

I created a new isuuse.

Old back links will break since you removed "_" compatability for topic URL.