search

EatEmAll / django-djeddit

Minimalistic Reddit clone developed as a Django reusable app
http://eatemall.pythonanywhere.com
Other
42 stars 13 forks source link

Added slugify and slug redirects #7

Closed Zerokami closed 6 years ago

Zerokami commented 6 years ago

I have added slug redirects and get_slug and get_absolute_slug.

Please accept my pull request.

This is my first Github pull request and I have put a lot of work trying it and debugging it.

I'll be adding a lot more features.

Also maybe pinax integration in a different branch.

Zerokami commented 6 years ago

Have fixed awesome-slugify import error. Please verify it.(I'm not sure if it's you who is supposed to verify it, but I see verified for everything except fixed awesome-slugify fix)

EatEmAll commented 6 years ago

Sorry for the long delay. I'm reviewing your pull request right now & checking why tests are failing. I'll keep you updated. Please make a pull request next time to a different branch. You can see why it can be a problem to accept a pull requests with failing tests to master.

Zerokami commented 6 years ago

Which branch should I make a pull request to?

Zerokami commented 6 years ago

There seems to be an error that Python 3.3 isn't loaded in Travis CI.

Then the migration for slug isn't there. So, you get a column doesn't exist in the test.

Then the slug URL redirects to 302 which fails some of the tests that check for 200 status and for thread template

I'm new to this and guidance is appreciated.

EatEmAll commented 6 years ago

You can make a pull requests to dev branch. I'll keep you updated for any issues I'll encounter.