EatTheFuture / camera_shakify

Other
1.09k stars 106 forks source link

Add feature to quickly enable/disable all shakes on a camera. #11

Open Ogyly opened 2 years ago

Ogyly commented 2 years ago

Hello. I like your addon. It gives cameras subtle camera shake. Thank you.

This is not Bug report but I have a question. I think your add-on moves camera every time camera moves, and it causes problem when I select a camera and move it in Camera to View mode. I always move camera in Camera to View mode, but If I add CameraShakify constraint to cameras it moves cameras when I don't play animation and it leads to strange and unintentional camera movement when I am in Camera to View mode. Right now I disable all actions of CameraShakify empties when Blender doesn't play animation using python script. I think it's better to stop CameraShakify action constraint when we don't play animation. If we check how your add-on moves camera, we play animation always, it means when we don't play animation, your add-on constraints don't need to be enabled. What do you think? It will cause other problems?

cessen commented 2 years ago

This sounds like a duplicate of issue #1?

What do you think? It will cause other problems?

I don't think it would be good for it to be automatic based on whether the animation is playing or not. Sometimes you want to frame a shot while accounting for the effects of the shake, or you're using the arrow keys to frame-step through an animation. So if the shake is always disabled outside of playback, the user has an inconsistent view of what the camera sees.

But having a quick and easy way to manually enable/disable the shake on a camera probably makes sense. Ultimately, though, this is a Blender issue: it doesn't properly account for constraints in the Camera to View feature.

Ogyly commented 2 years ago

ah you mentioned it already. I didn't check it. Option to disable all camera shakes temporarily will be useful.

cessen commented 2 years ago

Sounds good! I've changed the title of this issue to track this. Thanks for the idea!

schroef commented 1 week ago

Perhaps this solves it. This is a toggle which enables/disables all constraints when the panel is "disabled"

https://github.com/user-attachments/assets/bee7eb2b-a630-4567-b9d1-3913d407b5d3