search

EatTheFuture / camera_shakify

Other
1.08k stars 105 forks source link

Shakify making playback go from 30 fps to 1 fps #23

Open loicbramoulle opened 9 months ago

loicbramoulle commented 9 months ago

Blender Version 3.6.4 and shakify version: 0.2.0

Describe the bug Scene plays at 1fps when adding shakify, back at 30fps when removing it (only 1 shakify layer, "The Closeup"

To Reproduce I'm sorry, I'm not sure there's any step I can describe, I have only 1 cam, only 1 scene in this file, no special collection instance or NLA tracks ect.. just 1 chara, 1 enviro, 1 cam. I could share the file but it's under NDA.

Expected behavior As I understand shakify just adds a NLA track, I don't see how it could make a scene crawl (rtx3090, i9, 64gb ram)

cessen commented 8 months ago

I'm unable to reproduce this issue on my machine.

I could share the file but it's under NDA.

If there's any way you can remove the NDA parts of the file, while still reproducing the issue, and upload that, that would be extremely helpful. It's going to be very difficult to track this down without being able to reproduce it.

As I understand shakify just adds a NLA track

That is incorrect, Camera Shakify doesn't use the NLA at all. It instead sets up a hidden camera rig that the addon UI manages behind the scenes.

Nevertheless, I agree that this is very strange, because nothing Camera Shakify does should have any meaningful performance impact. It's only doing very simple, cheap things.

loicbramoulle commented 8 months ago

Hi Nathan, thanks for your answer, here is the file (didn't pack the textures, but I can still confirm the bug on my end, 1 fps with any shakify preset, 30 when removed) https://www.dropbox.com/s/yazhdokkdet5xb1/Old_Man_A010.blend?dl=0 (will delete once you found time to have a look) Just realized I could have tested on my other system, but still worth having a look on yours probably. Thanks !

cessen commented 8 months ago

Thanks for the file! I've downloaded it now.

Yeah, I'm getting the same issue with that file. Interestingly, even if I delete everything in the scene other than the camera and shakify rig, it's still super slow. But if I create a new fresh file and add some camera shakes, it's buttery smooth. So something weird is definitely going on.

I'm a bit crunched for time right now, so I can't make any promises about when I'll track this down. But I'll try to do it sooner rather than later. In the mean time, you might try appending everything into a new file, and see if that fixes it, since it doesn't seem to have anything to do with the rest of the scene setup.

loicbramoulle commented 8 months ago

Thanks a lot, yes pretty odd. For now I'm adding shakify when rendering and removing it after hehe, but yes it's likely that appending the scene in a fresh file will solve the issue, thanks blender gods that this is a thing, data-blocks. (lol Maya..). I'm starting to reach a point in blender where I see and report one very mysterious behaviour like that nearly every week haha, mostly with linked-data/overides, NLA, multi-scene files ect..

loicbramoulle commented 7 months ago

Just an update on this, I'm still using this file for a client job, and I tried to bake the shakify and delete it, and this way it is also 2 fps instead of 30. Then if I delete all the baked keyframe, and so back to a static camera, it still lags 2fps... really weird. Only fix is to delete the camera, like if it was cursed. I tried appending the scene in a blank file, same issue, the curse carries. Only thing that saved the camera is 50 undo steps. Then I tried to manally record hundreds of keyframes on it with "Real Time Animation" addon, and 30 fps, so it's really the combo of some mysterious reason in that scene + shakify, both together introducing a curse on any cameras.