EatTheFuture / camera_shakify

Other
1.09k stars 106 forks source link

Doesn't work on Blender v4.0 #24

Closed basicusername123 closed 4 months ago

basicusername123 commented 9 months ago

Blender 4.0 My version of Blender simply can't run Camera Shakify. Today i tried using this and all of a sudden it would not appear. I need to know why. To put it short, It won't appear.

To reproduce, just install and try to run on v4.0

Expected: Run perfectly

cessen commented 9 months ago

I'm unable to reproduce the issue. Freshly downloading the camera shakify addon and installing it on Blender 4.0 is working fine for me.

Can you provide any more details of exactly the steps you're taking that result in this? And can you launch Blender from the console and paste what it outputs here?

damankarora commented 7 months ago

Getting the following error on running on Blender 4.1

Screenshot 2024-04-09 at 1 37 07 AM

Workaround that I did: in init.py, L.No: 209, 210 I cast the float value into a string.

Can you tell me how it can impact the functionality of the addon effect?

constraint.frame_start = int(action_range[0]) constraint.frame_end = int(action_range[1])

damankarora commented 7 months ago

Getting the following error on running on Blender 4.1 Screenshot 2024-04-09 at 1 37 07 AM

Workaround that I did: in init.py, L.No: 209, 210 I cast the float value into a string.

Can you tell me how it can impact the functionality of the addon effect?

constraint.frame_start = int(action_range[0]) constraint.frame_end = int(action_range[1])

@cessen

cessen commented 7 months ago

Are you sure you actually downloaded the latest CameraShakify? Because the error you're getting looks identical to issue #6 which was fixed quite a while ago.

Other people have also filed the same issue (e.g. #8), and it always turns out they were using an older version of CameraShakify. I don't know where people are downloading these older versions from. But to get the latest version, you should always be downloading from this github repository.

cessen commented 4 months ago

Closing due to this likely being an old bug that's already fixed, and a lack of response from the reporters to say otherwise.

damankarora commented 4 months ago

Closing due to this likely being an old bug that's already fixed, and a lack of response from the reporters to say otherwise.

Can you please share PR of the fix you did? I feel i was on the latest version. I downloaded the zip directly from this repo.

cessen commented 4 months ago

@damankarora In the error message in your screenshot, you can see that the version of Camera Shakify you have has the line:

constraint.frame_start = action_range[0]

However, if you look at the same part of the file in this repo those same lines are the following:

https://github.com/EatTheFuture/camera_shakify/blob/113f761615f18e1916f21a5702eba144fdce2b20/__init__.py#L210-L211

The floor and ceiling functions return ints, so that addresses this same issue. The floor and ceil calls were added about two years ago in https://github.com/EatTheFuture/camera_shakify/commit/3088d52e1090bd71a5d04f110663204e372875b5.

damankarora commented 4 months ago

@damankarora In the error message in your screenshot, you can see that the version of Camera Shakify you have has the line:

constraint.frame_start = action_range[0]

However, if you look at the same part of the file in this repo those same lines are the following:

https://github.com/EatTheFuture/camera_shakify/blob/113f761615f18e1916f21a5702eba144fdce2b20/__init__.py#L210-L211

The floor and ceiling functions return ints, so that addresses this same issue. The floor and ceil calls were added about two years ago in 3088d52.

In the latest file, it seems fine. Floor and ceil will return non floating numbers. I don’t clearly remember where my friend had downloaded your plugin from. Probably that source is not updated. Anyhow, thanks for clarifying and apologies for wasting your time.

cessen commented 4 months ago

No worries! It happens.

I don’t clearly remember where my friend had downloaded your plugin from. Probably that source is not updated.

If you can ask your friend where he got it, I would really like to know. I get this same bug report repeatedly, and I would really like to find out where people are getting this outdated version so I can ask whoever it is to update the link to just point at this repo.