EatTheFuture / image_tools

Eat the Future's collection of image/color tools.
Other
74 stars 6 forks source link

LUT maker export crash on OSX #5

Closed elizarification closed 2 years ago

elizarification commented 2 years ago

Clicking the export buttons causes LUT maker to exit on Big Sur on M1. Tried giving it disk access -- didn't help. The exit message:

thread 'main' panicked at 'Attempted to construct an Id from a null pointer', /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/objc_id-0.1.1/src/id.rs:62:9 note: run with RUST_BACKTRACE=1 environment variable to display a backtrace Saving session... ...copying shared history... ...saving history...truncating history files... ...completed.

[Process completed]

cessen commented 2 years ago

Thanks for the report! I'll look into this the next chance I get (I don't personally have an Apple system, so it might be a little bit... sorry!).

elizarification commented 2 years ago

Thanks! If I can help in any way, don't hesitate to ask.

g3ntile commented 2 years ago

Hi! I use a mac (hackintosh in fact) and I have exactly the same issue! (exactly to the letter, the same error) I can add that I have no /Users/runner/ folder, so it may be something hardcoded somewhere causing the crash. I tried HDRI Merger and it worked flawlessly, and saved the .hdr with no issues, so I bet that it's something really easy to fix, like a typo or something. This is an awesome tools, really looking forward to test it. I don't code, so I can't help with that, but I can assure I'll test the builds :-) And thank you for taking the time to make this available on macs too!

cessen commented 2 years ago

I tried HDRI Merger and it worked flawlessly, and saved the .hdr with no issues, so I bet that it's something really easy to fix, like a typo or something.

Ah! This is super helpful, actually. I think I might know what it is then (not 100% sure, of course). I'll try my hand at fixing it, and make a dev build for you guys to test.

Thanks!

And thank you for taking the time to make this available on macs too!

Of course! I want these to be usable by as many people as possible. It's of course hard for me to test on Mac, since I don't own one. But my intention, at least, is to make everything work just as well on Mac as on Linux and Windows.

cessen commented 2 years ago

I've made a development build with the potential fix included: https://github.com/EatTheFuture/image_tools/releases/tag/dev_build-2022_01_09-e4b338f

If either of you get the chance to test it out and let me know if the bug is actually fixed or not, I'd really appreciate it!

Thanks!

g3ntile commented 2 years ago

Yes! It worked! it saved the file :-) now I can test the rest of the workflow Thank you very much!!

cessen commented 2 years ago

Awesome! I'll close this as fixed, then. If you run into anything else, please don't hesitate to file another issue!

cessen commented 2 years ago

This is now released in v0.3.0: https://github.com/EatTheFuture/image_tools/releases/tag/v0.3.0