search

Eaternity / eaternity-edb-solution

MIT License
1 stars 1 forks source link

feature/save csv #26

Closed mcmunder closed 7 years ago

mcmunder commented 7 years ago

Heyho, in case someone wants to look at this ;-)

mklarmann commented 7 years ago

In einer reactconf Präsi sagen Sie dass man das yarn.lock mit commiten soll.

Am 03.04.2017 um 10:54 schrieb ajaggi notifications@github.com:

@ajaggi commented on this pull request.

sonst schauts prima aus - und nicht nach viel code ;)

In yarn.lock:

@@ -3251,6 +3251,12 @@ flat-cache@^1.2.1: graceful-fs "^4.1.2" write "^0.2.1"

+flat@^2.0.0: @mcmunder wenn sich das so viel ändert, das lockfile auf gitignore tun? Ich versteh yarn noch nicht ganz...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

mcmunder commented 7 years ago

Manu is right, the lockfile is key to yarns functionality and should be committed. See here: https://yarnpkg.com/blog/2016/11/24/lockfiles-for-all/

mcmunder commented 7 years ago

Dann merge ich das mal und mache einen release?