search

Eawag-AppliedSystemAnalysis / Simstrat

Simstrat - 1D lake model
http://www.eawag.ch/en/department/surf/projects/simstrat/
GNU General Public License v3.0
18 stars 8 forks source link

Missing parenthesis in strat_temp.f90 #47

Closed robertladwig closed 3 years ago

robertladwig commented 3 years ago

I noticed issues when compiling the newest Simstrat source code as a parenthesis was missing in strat_temp.f90 which gave gfortran problems (probably no error under fort?).

I assume that this line adds the heat flux as Q/(cp rho V) A and A is taken as the middle point of the cell? Therefore I added the missing parenthesis to the end of the line: `sources(ubnd_vol) = sources(ubnd_vol) + state%heat/rho_0/cp/grid%h(ubnd_vol)grid%Az(ubnd_fce)/(grid%Az(ubnd_fce) + grid%Az(ubnd_fce - 1)2 to sources(ubnd_vol) = sources(ubnd_vol) + state%heat/rho_0/cp/grid%h(ubnd_vol)grid%Az(ubnd_fce)/(grid%Az(ubnd_fce) + grid%Az(ubnd_fce - 1)*2)`

f-baerenbold commented 3 years ago

Hi Robert, Thanks for spotting the error. I actually forgot to compile it before pushing. However, the parenthesis is still not quite at the right place: it should be before the "2". If you correct this then I can merge the pull request. Otherwise, I can also correct it myself later.

robertladwig commented 3 years ago

Gotcha, changed it to before the parenthesis.

f-baerenbold commented 3 years ago

Thanks