Trims in flight-modes should not be flight-modes specific by default

[GoogleCodeExporter]

Which board (stock / gruvin9x / sky9x / Taranis) are you using?
stock 

What is your openTx FW version?
latest

What is your openTx EEPROM version?
latest

What steps will reproduce the problem?
1. Create a new flight mode FM1
2. **forget** to change FM1 trims, so they be taken from FM0
3. Fly the model on FM0, and trim the plan on the air.
4. Move to FM1 (I did it while turning with wind) , Since FM1 is not trim, the 
plane is out of control
5. Plane crashed :-(

What is the expected output? What do you see instead?
I suggest to have a flag in the non-model main page a global setting that 
disable specific Flight Mode trim (I do not like them)
Other option is to change the flight-mode **default**, so the trims are taken 
from FM0 (by default!) and the ones that actually need it will change it.

Users may not expect the plane to be out of trim when changing the 
flight-modes, if they use the flight-mode for different expo.

Original issue reported on code.google.com by offer.sh...@gmail.com on 4 May 2013 at 5:37

[GoogleCodeExporter]

One of the things that are peculiar to a flight mode are trims.
By default especially in gliders where a flight mode enable a series of mix, 
defaulting all trims to FM0 will result in a never trimmed model.

A single trim set in all flight modes is a non standard setup, so the user 
should take care of it.

Original comment by romolo.m...@gmail.com on 4 May 2013 at 6:34

[GoogleCodeExporter]

I am not flying gliders, and I did crash my plane last week due to this 
behavior.

If gliders need it, and for other it's dangerous, lets add global option, this 
way the user will choose how it's transmitter should behave.

Today I change (through Companion) all my 6 models, for each of the flight mode 
(5 FM) x 4 trims = 96 settings, and I still     
anxious that I missed something, and what happen in my next model.

Offer

Original comment by offer.sh...@gmail.com on 4 May 2013 at 10:35

[GoogleCodeExporter]

If you just need to change expos then use switches to enable them and not 
flight modes. Split trims is an intrinsic properties of flight modes.

You state:
"Users may not expect the plane to be out of trim when changing the 
flight-modes, if they use the flight-mode for different expo."

I will say:
User must expect trims to behave like in any other radio with flight modes, and 
to read manual about features before using them. 
BTW even in high end radios the GROUP option (common to all phases) should be 
enabled as the default is SINGLE. (phase specific)

I'm sorry, but I'm against this change, as not only in gliders but also in 
scale models with flaps and landing gears, individual FM trim is a must to 
adjust the model in different aerodynamic configurations (ie full flap or gear 
down).

About an option in General settings, to create new models with trims common to 
all FM, that's another issue.

Original comment by romolo.m...@gmail.com on 5 May 2013 at 7:31

[GoogleCodeExporter]

Ok with Romolo. Not only because I'm a glider addict, but because user have to 
check a minimum what he does. That's the price to pay...

Original comment by f.ague...@wanadoo.fr on 5 May 2013 at 8:57

[GoogleCodeExporter]

Ok. I will wait for André's opinion as well before closing this issue.

Original comment by bson...@gmail.com on 5 May 2013 at 9:03

[GoogleCodeExporter]

Just one more element : as soon as you use flight mode to change servo throw 
(by stick dual-rate or mixer ratio), and that is the most commun use of flight 
mode, you need imperatively to distinguish stick trims, because servos throws 
are never perfectly linear.

Original comment by f.ague...@wanadoo.fr on 5 May 2013 at 9:44

[GoogleCodeExporter]

Received today from André: "I agree, modes should stay how they are. THE 
reason to use flight modes is to take advantage of the separate trims, 
especially on opentx as that's basically the only thing they do."

Original comment by bson...@gmail.com on 6 May 2013 at 6:55

• Changed state: Invalid

[GoogleCodeExporter]

I do not agree with all, I do agree for some however.
Thanks anyway, and keep the good work.
Maybe one day I will have the time to compile it and do the change for myself.

Offer

Original comment by offer.sh...@gmail.com on 6 May 2013 at 8:36

[GoogleCodeExporter]

If you need it, the change is really easy to do. You will modify the 
modelDefault() function with this code (not tested):

for (uint8_t phase=1; phase<MAX_PHASES; phase++) {
  PhaseData *p = phaseaddress(phase);
  for (uint8_t idx=0; idx<4; idx++) {
    p->trim[idx] = TRIM_EXTENDED_MAX+1;
  }
}

Original comment by bson...@gmail.com on 6 May 2013 at 8:43

[GoogleCodeExporter]

What could be nice is something like a "copy trims to all modes" function. 
That way you trim your plane in mode 0, then land and copy trims to other modes 
so you have a good starting point. 

On ARM we could have the new settings popup appear where we select which modes 
to copy to with checkboxes.

Original comment by bernet.a...@gmail.com on 6 May 2013 at 9:30

[GoogleCodeExporter]

We already have trim to offset which adjust the trims in all phases.
But i still prefere the old school of mechanical adjustment.
Maybe I'm wrong, but normally on maiden flight I fly in default mode, I trim 
the plane, I land and adjust mechanical centers or PPMCA to get the proper 
centers while I reset trims...
I repeat this process until I'm fully satisfied when trims are at 0.
then I start trimming the model in other fm.
Am I of the too old school ?

I really don't like to risk, with a copy trim function, to reach a condition in 
which I cannot adjust trims in while I'm flying as maybe I'm already at the end 
of run.

Original comment by romolo.m...@gmail.com on 6 May 2013 at 11:24

[GoogleCodeExporter]

True, I'm fine with the current trims->Offsets. 

Original comment by bernet.a...@gmail.com on 8 May 2013 at 9:12

[GoogleCodeExporter]

On many transmitters you have the choice to apply trim to all flight mode or 
not.
This morning, while discovering openTx on Taranis I was using flight-mode 0 
with an Heli setup, I can say it is a problem to not have a common trim for 
normal/idle-up modes... 
And about trims to offsets : this is ok for an initial setup, but not to 
compensate in live for different battery weight or position, affecting the 
model COG (just an example)
So, really, this otion is desirable ! Thanks for your work.

Original comment by aerofred...@gmail.com on 18 Aug 2013 at 1:29

[GoogleCodeExporter]

We DO have the choice of trims being flight mode specific or not. This issue 
was only about changing the default behavior (currently separate by default). 
See manual. 
http://code.google.com/p/opentx/wiki/OpenTx_FrSky_EN#Flight_modes

Original comment by bernet.a...@gmail.com on 18 Aug 2013 at 2:19

[GoogleCodeExporter]

I (the requester of this change) still think the default should be different or 
at least a single set per model.

I think that when building so feature rich program, that each group of user, 
use other part of the features, the concept should be:
"if you do not use it, the default is good enough for you"

Note that on a new model i have to set 16 different setting to acomplish this 
task (4 flight mode * 4 chnnels, all need to set to 0)

I lost a plain because of that, and today to each person of my group that i 
encorege to install openTx (and i do!), This is the first and only warning i 
need to advise him!!

Please consider again.

Offer

Original comment by offer.sh...@gmail.com on 20 Aug 2013 at 6:57

[GoogleCodeExporter]

I think you got the methodology wrong.

You should do a first flight using ONLY the default mode, trim your model, 
land, and then adjust either your linkages (preferably) or the subtrims (e.g. 
via the Trims -> Offsets function) so that your trims in the default mode are 
zero again.
THEN once the default flight mode is OK try the other ones, and trim if needed 
by the different configurations (as the mode-specific trims are still zero, and 
your aircraft was trimmed correctly when trims are zero by doing the described 
procedure you're as close as it gets).

This is the correct way to do it not only for openTx, but with other radios 
too. 

Original comment by bernet.a...@gmail.com on 20 Aug 2013 at 8:25

[GoogleCodeExporter]

Hi André

About the methodology
You are totaly correct about "first flight + trim model + adjust linkages" (it 
was my mistake in the first place)

However, after did all this, now i like to change the 6cell 4000AH battery to 
lighter one for a single flight, so i need to add small trim, it should be same 
trim for all flight mode, 
so this mean that I must set each model with the 16 setting as described above.

Can we agree on a setting per model, somthing like:
'Allow different trim per flight mode' = true/false

BTW, I can also download the code and help implementing it if needed

Offer

Original comment by offer.sh...@gmail.com on 21 Aug 2013 at 5:19

[GoogleCodeExporter]

Ah, then it's something different from what this issue talks about - you'd want 
flight-mode specific trims to be _added_ to the default mode's ones. There have 
also been discussions about this already. Please make a separate issue for 
that. 

Original comment by bernet.a...@gmail.com on 21 Aug 2013 at 6:44

[GoogleCodeExporter]

I opened a different request with revised requirement
So this request is deprecated.

The new request is under:
https://code.google.com/p/opentx/issues/detail?id=114&thanks=114&ts=1377082951

Original comment by offer.sh...@gmail.com on 21 Aug 2013 at 2:31