search

EbonJaeger / nosquint

NoSquint is a Firefox add-on that allows you to adjust the text-only and full-page zoom levels as well as color settings both globally (for all sites) and per site.
https://urandom.ca/nosquint/
The Unlicense
12 stars 1 forks source link

2.2.0: "Disable background images" stopped working #8

Closed Gittyperson closed 6 years ago

Gittyperson commented 6 years ago

Thank you for this update. I think something in this version is interfering with this feature. Check these two websites:

https://www.athenstransport.com/ http://www.cinemagazine.gr/

In 2.1.10 Disable background images works. In 2.2.0 it doesn't.

On the first website only, if you toggle the option the background will disappear, but it will re-appear on the next refresh. On the second website, toggling does nothing.

Pale Moon 28.0.0a4, Win 10 Pro x64

EbonJaeger commented 6 years ago

The same appears to be true for all of the colorizing options. I'll dig around and try to find what change caused this.

EbonJaeger commented 6 years ago

It looks like the styling is being applied before the rest of the website's styling, and thus is being overridden.

**EDIT: Hm. Now I'm not so sure.

**EDIT 2: Nope, something else is happening.

EbonJaeger commented 6 years ago

Okay, I figured out that all this was caused by moving to the new global TabsProgressListener. :/

I reverted that change, and did some minor cleanup. Will publish the update on PM shortly. Sorry about that.