EbookFoundation / free-programming-books

:books: Freely available programming books
https://ebookfoundation.github.io/free-programming-books/
Creative Commons Attribution 4.0 International
333.68k stars 61.13k forks source link

Add German podcast Python Podcast #11224

Closed jk4e closed 2 weeks ago

jk4e commented 3 weeks ago

What does this PR do?

Add resource: Adding the first German podcast to the repository

For resources

Description

A German podcast about the Python programming language.

Why is this valuable (or not)?

Great podcast in German about Python. I am a listener myself. Podcast started in 2018.

How do we know it's really free?

It is free. The site is run by the podcasters themselves.

For book lists, is it a book? For course lists, is it a course? etc.

It is a fantastic podcast in the German language! (podcast)

Checklist:

Follow-up

eshellman commented 3 weeks ago

@Thenlie Do you understand why the check on this PR is failing?

Thenlie commented 2 weeks ago

@Thenlie Do you understand why the check on this PR is failing?

This one is strange, I am not seeing anything obviously wrong with the run. It determines the correct artifacts to download but then simply fails without much error message. Can we re-run the entire job and see if that has any impact?

Comparing to a successful run, https://github.com/EbookFoundation/free-programming-books/actions/runs/9923035194/job/27412794189?pr=11185, the only difference I am seeing is the Runner Image Provisioner which I wouldn't expect to break this. Will continue searching for a solution.

Thenlie commented 2 weeks ago

@eshellman I have recreated an identical PR #11229 and am seeing the same problem, so re-running probably will not help. Will continue to investigate on that branch and update here with anything I find.

Thenlie commented 2 weeks ago

Alright, made some progress, though not totally there. It seems this issue has popped up recently for a lot of people on GitHub. https://github.com/actions/download-artifact/issues/339. There are a few possible solutions, though nothing definitive. I have tried removing the name field from the download step and at least one of the artifacts successfully downloaded when I did that. I have to step away now but will continue digging into this ASAP.

eshellman commented 2 weeks ago

@jk4e would you be able to update your branch from main? That should fix the build thanks to @Thenlie 's research. If you prefer, you could also start fresh from the current main.

jk4e commented 2 weeks ago

Everything looks fine now. Sorry, that my PR caused so much trouble/issues. Thanks for your help @Thenlie! Thank you so much for all the work you put into this fantastic project @eshellman!

Thenlie commented 2 weeks ago

Everything looks fine now. Sorry, that my PR caused so much trouble/issues.

No problem whatsoever! If anything, this PR just highlighted an existing bug, so thank you <3