[NO REVIEW] Testing PR #11224 - Githubissues

EbookFoundation / free-programming-books

:books: Freely available programming books

https://ebookfoundation.github.io/free-programming-books/

Creative Commons Attribution 4.0 International

333.68k stars 61.13k forks source link

[NO REVIEW] Testing PR #11224 #11229

Closed Thenlie closed 2 weeks ago

Thenlie commented 2 weeks ago

What does this PR do?

Improve repo

For resources

Description

Trying to debug why the download artifact step is failing on #11224.

After seeing this issue https://github.com/actions/download-artifact/issues/339 it was suggested to remove the name property from the download step. When I did this, the markdown files would successfully download. See the run here https://github.com/EbookFoundation/free-programming-books/actions/runs/10540794299/job/29205861615?pr=11229. The yml file still failed to download, but this might be fine since it is not a file that will be regularly updated. I think this will unblock the PR in question, but we may want to do a bit more digging to ensure it works for all files.

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

[ ] Read our contributing guidelines.
[ ] Search for duplicates.
[ ] Include author(s) and platform where appropriate.
[ ] Put lists in alphabetical order, correct spacing.
[ ] Add needed indications (PDF, access notes, under construction).
[ ] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

eshellman commented 2 weeks ago

i really appreciate your help on this!