Fix case. Php < PHP - Githubissues

EbookFoundation / free-programming-books

:books: Freely available programming books

https://ebookfoundation.github.io/free-programming-books/

Creative Commons Attribution 4.0 International

337.12k stars 61.6k forks source link

Fix case. Php < PHP #11572

Closed hstsethi closed 2 weeks ago

hstsethi commented 2 weeks ago

What does this PR do?

Fixes case of "PHP" in Hindi booklist.

For resources

Description

Why is this valuable (or not)?

I believe it is.

How do we know it's really free?

Not applicable

For book lists, is it a book? For course lists, is it a course? etc.

Not applicable

Checklist:

[X] Read our contributing guidelines.
[X] Search for duplicates.
[X] Include author(s) and platform where appropriate.
[X] Put lists in alphabetical order, correct spacing.
[X] Add needed indications (PDF, access notes, under construction).
[X] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

eshellman commented 2 weeks ago

Use the titles as given by the resources.

hstsethi commented 2 weeks ago

@eshellman The title tag in both of resources use "PHP".

eshellman commented 2 weeks ago

agreed, but the rest of the titles don't match

hstsethi commented 2 weeks ago

agreed, but the rest of the titles don't match

I am sorry, but I don't understand. Do you mean the heading?

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/books/free-programming-books-hi.md
  67:1-68:87  warning  Alphabetical ordering: swap l.68 and l.67  alphabetize-lists  remark-lint

hstsethi commented 2 weeks ago

Don't invent titles! Use the title given by the resource.

I am really sorry for the inconvenience caused. I have followed your suggestions. Please review.

eshellman commented 2 weeks ago

Thanks, and welcome to free-programming-books!