EbookFoundation / free-programming-books

:books: Freely available programming books

https://ebookfoundation.github.io/free-programming-books/

Creative Commons Attribution 4.0 International

339.74k stars 61.81k forks source link

[WIP - No Review] Upgrade download-artifact action to v4 #11751

Closed Thenlie closed 2 weeks ago

Thenlie commented 2 weeks ago

What does this PR do?

Improve repo

Description

actions/download-artifact v3 is being deprecated by the end of this year. We need to upgrade to v4 to avoid future issues. Unfortunately, due to https://github.com/actions/download-artifact/issues/339 this might not be a straight forward as updating. This PR will test that concern.

11749

Checklist:

[ ] Read our contributing guidelines.
[ ] Search for duplicates.
[ ] Include author(s) and platform where appropriate.
[ ] Put lists in alphabetical order, correct spacing.
[ ] Add needed indications (PDF, access notes, under construction).
[ ] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

eshellman commented 2 weeks ago

that's very strange

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

eshellman commented 2 weeks ago

Oh, I get it, you're testing a bad linter case. carry on...

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

github-actions[bot] commented 2 weeks ago

Linter failed, fix the error(s):

  free-programming-books/casts/free-podcasts-screencasts-de.md
  9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

Thenlie commented 2 weeks ago

Closed this just to avoid all the lint error noise on the final PR.