search

EccentricVamp / EccentricTome

Minecraft mod for holding books
https://modrinth.com/mod/eccentric-tome
GNU Lesser General Public License v3.0
5 stars 8 forks source link

compat and blacklists for mod items #22

Closed NyanMC closed 2 years ago

NyanMC commented 2 years ago

adds compat for enigmatic legacy's guide book "the acknowledgment", and blacklists some items which are used (and consumed) in crafting the added blacklisted items are as follows: dark utils: galactic, runelic, and restoration tomes (or "books" going by their resource name) (these items are applied via smithing table and are consumed on use, and the internal names are presumably the 1.16 equivalent to the tomes) projecte: tome of knowledge (this item is only needed once, and you can easily void your entire tome on accident with it) quark: ancient tomes (same as the dark utils items, but these are applied via crafting table, they're still consumed on use though) the vanilla minecraft enchanted book is on here as despite the mod having a built-in blacklist for minecraft it does not prevent enchants from other mods from going into the book

EccentricVamp commented 2 years ago

*Facepalm*

I just realized I butchered this pull request. I thought this was a pull request for main.

You did the right thing and opened this pull request on the 1.16.5 branch but I wasn't paying attention, sorry! The Dark Utilities changes have been made in https://github.com/EccentricVamp/EccentricTome/pull/23.

Thanks for opening up a pull request! I hope I didn't scare you away with my shenanigans.

NyanMC commented 2 years ago

Since I don't have a good way to filter those out, might as well embrace them.

...but you do have a way, that's why i added minecraft:enchanted_book to the blacklist in my pull request. that causes all mod enchantments to be filtered out, as they are all registered under the vanilla item unless they handle the enchantment in a weird way (and yes, i did test that, it works). i don't know why it doesn't when enchanted books aren't explicitly on the blacklist, and i won't pretend i do. i can still remove the line if you want, i just wanted to clarify that first.

also,

I hope I didn't scare you away with my shenanigans.

you're fine, i didn't even see what you said until the time of making this comment, so if you said something originally and deleted it then i didn't see it.

EccentricVamp commented 2 years ago

they are all registered under the vanilla item

I didn't realize that. Good to know

i can still remove the line if you want

No need. I might investigate enchanted books more in the future, but in the meantime lets get this merged.

I think I'll publish sometime this weekend as Eccentric Tome 1.8-beta.