search

EccentricVamp / EccentricTome

Minecraft mod for holding books
https://modrinth.com/mod/eccentric-tome
GNU Lesser General Public License v3.0
5 stars 9 forks source link

Books disappearing from Tome #25

Closed Dubya72 closed 1 year ago

Dubya72 commented 2 years ago

Versions

Describe the bug In ATM7 and Direwolfs Modpack all the books in the tome were deleted except the current book loaded. I don't know when it happed, but when I went to change books to look something up they were all gone.

To Reproduce Don't know how to reproduce it.

Expected behavior

Screenshots

Additional context

EccentricVamp commented 2 years ago

Do you know if you had recently updated versions of the Eccentric Tome? (for example 1.3.1 → 1.8.0)

I'll try to investigate sometime this weekend.

Dubya72 commented 2 years ago

I didnt update anything. I had just downloaded Direwolfs pack and it happened to me twice. I cheated the books back in after it happened the first time then it happened again. I only played his pack week or so.

Then a few days ago I tried ATM7 and it happened after 2 or 3 days. Both packs were unaltered from whatever the client downloaded. Direwolfs pack was on FTB launcher and ATM7 on Cursefoge launcher.

On Tue, Aug 16, 2022, 7:41 PM T. Luke Cloninger @.***> wrote:

Do you know if you had recently updated versions of the Eccentric Tome? (for example 1.3.1 → 1.8.0)

I'll try to investigate sometime this weekend.

— Reply to this email directly, view it on GitHub https://github.com/EccentricVamp/EccentricTome/issues/25#issuecomment-1217311680, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2Q34D4F75PEXTSNPKTWU5DVZQYKBANCNFSM56TJQBBQ . You are receiving this because you authored the thread.Message ID: @.***>

EccentricVamp commented 2 years ago

I did some digging

I recommend gathering logs if you start playing either of the mod packs again. If it is exceeding the 2 MiB limit, that should show up in the logs. Another thing that might help is keeping track of which guide books you've put into the Eccentric Tome.

Dubya72 commented 2 years ago

I have been playing ATM7 since I last emailed you and it hasn't deleted any books again so far. I will keep a list of the books I put in and send you the crash report if it happens again.

Thanks, CW

On Sat, Aug 20, 2022, 4:50 PM T. Luke Cloninger @.***> wrote:

I did some digging

  • Investigated the raw tome data for 1.18.2 to see if there were any leaks. Couldn't find anything
  • Searched for any known issues with NBTs (that's what Minecraft uses to store the Tome's data). Couldn't find anything
  • Looked up the max NBT size in 1.18.2. It's 2 MiB which should be more than enough to store the guide books
    • It is possible one of the guide books in ATM and DIrewolf20 is doing some really crazy stuff with NBTs and causing the Eccentric Tome to go over the 2 MiB limit. But I can't fix it unless I know which one it is

I recommend gathering logs if you start playing either of the mod packs again. If it is exceeding the 2 MiB limit, that should show up in the logs. Another thing that might help is keeping track of which guide books you've put into the Eccentric Tome.

— Reply to this email directly, view it on GitHub https://github.com/EccentricVamp/EccentricTome/issues/25#issuecomment-1221415009, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2Q34D7J2C3FNUMUE7TE56LV2FHI3ANCNFSM56TJQBBQ . You are receiving this because you authored the thread.Message ID: @.***>

EccentricVamp commented 2 years ago

I was doing some testing in 1.19.2 this morning. I think I managed to replicate the issue. Lost all the books in the Tome except for the one I was just using (Mystical Agriculture).

Books in tome

I don't think it's an issue with the NBT size limit anymore.

I immediately tried to do it again, but couldn't force it to happen. I'll continue investigating

Dubya72 commented 2 years ago

I had it happen to me again. I started a new world (ATM7), so all the books that you start the game with in the Tome were there, I put the quest book in there that you get for completing the quest. It worked fine after that. then I opened the EvilCraft book to look up something and that was the book that was loaded. I then went to the Blue Skies traders and got the Blue Skies book. I put it in the Tome and the rest of the books were still there. Then I turned on cheat mode, I always play with cheats enabled in case of problems, and then I went out of cheat mode. I then traded the blue skies trader for the blue igniter thing and then I went to look up something in the Blue Skies book and noticed that all the books were gone except for the EvilCraft book which was loaded.

CW

On Sun, Aug 21, 2022 at 11:39 AM T. Luke Cloninger @.***> wrote:

I was doing some testing in 1.19.2 this morning. I think I managed to replicate the issue. Lost all the books in the Tome except for the one I was just using (Mystical Agriculture).

Books in tome

  • Mystical Agriculture
  • Cooking for Blockheads I
  • Cooking for Blockheads II
  • Cooking for Blockheads #NoFilter edition

I don't think it's an issue with the NBT size limit anymore.

I immediately tried to replicate the issue, but couldn't cause it to happen again. I'll continue investigating

— Reply to this email directly, view it on GitHub https://github.com/EccentricVamp/EccentricTome/issues/25#issuecomment-1221580059, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2Q34D3UREYWPRLE4AH7KS3V2JLVZANCNFSM56TJQBBQ . You are receiving this because you authored the thread.Message ID: @.***>

EccentricVamp commented 2 years ago

I spent 4 or 5 hours today trying to replicate this in different versions. I had the most (worst?) luck on 1.19.2 in creative mode.

To get a better look at what was happening, I added some additional logging. Managed to catch the items disappearing in the log. The Tome was successfully converted to Mystical Agriculture. But when the revert started, the items were gone.

[27Aug2022 12:45:58.771] [Server thread/DEBUG] [eccentrictome/]: Converted Eccentric Tome
[27Aug2022 12:45:58.772] [Server thread/DEBUG] [eccentrictome/]: {display:{Name:'{"translate":"eccentrictome.name","with":[{"color":"green","text":"Mystical Agriculture"}]}'},"eccentrictome:is_tome":1b,"eccentrictome:mods":{cookingforblockheads:{0:{Count:1b,id:"cookingforblockheads:crafting_book"},1:{Count:1b,id:"cookingforblockheads:no_filter_edition"},2:{Count:1b,id:"cookingforblockheads:recipe_book"}}},"patchouli:book":"mysticalagriculture:guide"}
[27Aug2022 12:46:06.061] [Server thread/DEBUG] [eccentrictome/]: Reverting Eccentric Tome
[27Aug2022 12:46:06.062] [Server thread/DEBUG] [eccentrictome/]: {display:{Name:'{"translate":"eccentrictome.name","with":[{"color":"green","text":"Mystical Agriculture"}]}'},"eccentrictome:is_tome":1b,"eccentrictome:mods":{},"eccentrictome:version":1,"patchouli:book":"mysticalagriculture:guide"}

I think I'm getting closer to the root cause.

I wasn't able to replicate it again after catching it in the logs. So, this will probably take another week. Thanks for your patience

Gronglegrowth commented 2 years ago

I've been seeing this too in a pack I am working on, 1.18.2. The books in my tome are

EccentricVamp commented 2 years ago

I've pushed Eccentric Tome 1.9.0-beta which simplifies the mod's internal logic and expands logging. Since this bug doesn't cause crashes, the logging will be sent to .minecraft/logs/debug.log if your launcher supports it.

I'm going to be doing a bunch of testing this weekend (mostly just playing a personal mod pack). I'm trying to hunt down exactly when/where the bug occurs.

If you would like to assist the bug hunt, update to the beta version and post a comment with your debug.log immediately after the bug occurs.

ozhound commented 2 years ago

This just happened to me after many hours in a world and having most of the books added to the tome. This happened after a server restart. Im not sure if it is related, but another bug where i right clicked a mana spreader with a mana ring caused the mana spreader to eat the ring voiding it aparently. i logged off and when i started the server and logged in the next day, only the active book (botania) was loaded.

EccentricVamp commented 2 years ago

If you're still actively using the mod, I recommend upgrading to Eccentric Tome 1.9.0-beta. I was playing with it all weekend and encountered no issues. Fingers crossed that simplifying the logic fixed the bug since I still haven't been able to isolate the root cause.

This happened after a server restart.

Good to know. I haven't included anything server-side in my testing. I might start testing that if 1.9.0 doesn't fix it

Im not sure if it is related, but another bug where i right clicked a mana spreader with a mana ring caused the mana spreader to eat the ring voiding it

I think it's unrelated.

ozhound commented 2 years ago

This happened again last night for me

i believe it occurs when you switch from the standard inventory screen to a book which is triggered by clicking on the tab at the bottom of the inventory screen. In my case and using the ATM7 Modpack i cycled through the 2 options i had available to me.

2022-10-08_15 40 39 2022-10-08_15 40 42 2022-10-08_15 40 43

That last image shows a shortcut to opening the blue skies book. im unsure if this was loaded in the tome. maybe worth checking out

EccentricVamp commented 2 years ago

@ozhound Do you know which version of Eccentric Tome you were using?

ozhound commented 2 years ago

1.8.0

On Sun, 9 Oct 2022 at 00:19, T. Luke Cloninger @.***> wrote:

@ozhound https://github.com/ozhound Do you know which version of Eccentric Tome you were using?

— Reply to this email directly, view it on GitHub https://github.com/EccentricVamp/EccentricTome/issues/25#issuecomment-1272351732, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA325VNGVUN7MS4RBWUAT4LWCGNJNANCNFSM56TJQBBQ . You are receiving this because you were mentioned.Message ID: @.***>

Aedda commented 2 years ago

This just happened to me as well, using version 1.8.0, not sure what I did to trigger it though sadly.

ETA: I'm on MC 1.18.2

EccentricVamp commented 1 year ago

After a bunch of hours of testing, I think I've fixed it. This issue should be fixed in Eccentric Tome 1.9.0, which I just released.

Let me know if you're still seeing the issue after the update.

EccentricVamp commented 1 year ago

Closing this as completed. Leave a comment if you're still experiencing the issue.

EnterFor commented 1 year ago

@EccentricVamp Hello, excuse me, I am experiencing the same problem with the latest ATM7 module package, I noticed that the version in the package is 1.8.0, I found that you have fixed this problem. My question is, is there a command to retrieve preset books? Because I want to update this mod manually. My English is not good, the above text is from the translation software

EnterFor commented 1 year ago

I mean, is there any way to retrieve the birth book. I don't know if you can understand. I'm sorry

EccentricVamp commented 1 year ago

@EnterFor sorry, there isn't a command. If you want to get it back, you'll need to add the books back in manually, probably using creative mode. Check this thread on Reddit for more info: https://www.reddit.com/r/allthemods/comments/v651np/how_to_get_eccentric_tome_back_after_losing_it/