search

Ecdar / Ecdar-GUI

A graphical tool for modeling using ECDAR (Environment for Compositional Design and Analysis of Real Time Systems)
MIT License
3 stars 5 forks source link

Backend to engine #136

Closed Nielswps closed 1 year ago

Nielswps commented 1 year ago

- Replacement for broken PR #131 -

The PR changes 'backend' to 'engine' where engines are referenced, in order to be consistent with the rationalization of the architecture. However, some files still use 'backend', as they operate at an abstraction level, where 'engine' is an irrelevant implementation detail.

Nielswps commented 1 year ago

I have renamed the JSON property backend to engine, so any existing project will be assigned the default engine instead of the one specified for it. However, it turns out this happens no matter what and should be a separate issue

Brandhoej commented 1 year ago

@Nielswps. While reviewing the code I might have found a minor mistake. getNumberOfInstances returns the difference between the port ranges. However, is the end port not included? If son, then we should add one. Such that we get return this.portEnd - this.portStart + 1. I believe this is intended as the use in getEngineConnection does this. I also think that tryStartNewEngineConnection implies this behaviour.