Echelon9 / cxbx-shogun

shogun's mirrored branch of the Cxbx original Xbox emulator
GNU General Public License v2.0
33 stars 7 forks source link

Support DrawIndexedVerticesUP() on 5659 #4

Closed Echelon9 closed 10 years ago

Echelon9 commented 10 years ago

DrawIndexedVerticesUP() is not currently identified from the HLEDatabase on titles built with the 5659 version of D3D8 library. At present, the 5659 libraries are linked to 5558, which does have an OOVP pattern for this function.

So a broader pattern which matches the larger set of 5659 && 5558 is required.

Echelon9 commented 10 years ago

The OOVP pattern included an offset from EDI has been seen as 0xBC4 (5558) and 0xBD4 (5659).

By not searching for the value of the offset and matching a subsequent lowest common denominator null byte, the pattern works for 5659 && 5558.

Improved titles
Verified no loss of pattern matching or negative delta
Echelon9 commented 10 years ago

Resolved in PR #10