search

EchoLiao / hedgewars

Automatically exported from code.google.com/p/hedgewars
GNU General Public License v2.0
0 stars 0 forks source link

Schemes can be saved with same name, different casing #135

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
If you save a scheme with the same name as an existing scheme but with 
different casing then both appear in the frontend. Deleting one of them will 
delete both and only one of them is actually written to disk since restarting 
will remove one of them.

Original issue reported on code.google.com by gtamulti on 28 Dec 2010 at 2:37

GoogleCodeExporter commented 9 years ago 
i couldn't reproduce the exact bug you're reporting but there's definitely 
something wrong with scheme creation/deletion right now.
we'll investigate it further

Original comment by vittorio...@gmail.com on 23 Feb 2011 at 3:25

GoogleCodeExporter commented 9 years ago

Original comment by vittorio...@gmail.com on 23 Feb 2011 at 3:25

GoogleCodeExporter commented 9 years ago

Original comment by vittorio...@gmail.com on 5 Apr 2011 at 9:41

GoogleCodeExporter commented 9 years ago

Original comment by vittorio...@gmail.com on 18 Apr 2011 at 9:46

GoogleCodeExporter commented 9 years ago

Original comment by vittorio...@gmail.com on 22 Aug 2011 at 2:25

GoogleCodeExporter commented 9 years ago 
Has no relation to issue #146, can't reproduce.

Original comment by unC0Rr on 2 Sep 2011 at 8:41

GoogleCodeExporter commented 9 years ago

Original comment by vittorio...@gmail.com on 3 Sep 2011 at 9:18

GoogleCodeExporter commented 9 years ago 
yeah i can't reproduce it either on linux, anyone willing to test this on 
windows or mac which have a case insensitive file system?

Original comment by vittorio...@gmail.com on 3 Sep 2011 at 9:21

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Actually it's not a problem with schemes.ini since that uses uniquely numbered 
names for each scheme/INI label.

There is a problem with writing weapons.ini since it uses the weapon config 
name for each config and at least on Windows, INI sections are case insensitive.

http://doc.qt.nokia.com/stable/qsettings.html#section-and-key-syntax

Original comment by gtamulti on 3 Sep 2011 at 6:09

GoogleCodeExporter commented 9 years ago 
I spent some time on this, here are some updates

* for weapons:
1. you cannot delete default sets
2. you cannot overwrite default sets
3. if the new set has different casing from the default one, both can exist
4. if the new set has different casing from a custom one, the former will be 
ignored

(not critical, but the 4th point could be fixed)

* for schemes:
1. you cannot delete default schemes
2. you can give a name of a default scheme and both will be listed
3. if the new scheme has different casing from the default one, both can exist
4. if the new set has different casing from a custom one, both can exist

(point number 3 can actually cause issues and should be fixed before release)

Original comment by vittorio...@gmail.com on 23 Oct 2012 at 5:52

GoogleCodeExporter commented 9 years ago 
Does this still happen with the new physfs backend?

Original comment by vittorio...@gmail.com on 27 Aug 2013 at 7:38