when recording starts, mouse is trapped in a invisible window

[GoogleCodeExporter]

1. would be nice that fps is not shown on videos
2. when deleting a video, also the preview in VideoTemp should be deleted
3. since hw usually runs at vsync, the video framerate should be 60 by default
4. could prompt a warning when framerate is non standard
5. the video recording options should stay in their own tab in the setting page
6. bitrate needs to be increased

all above is imho and open for discussion

Original issue reported on code.google.com by vittorio...@gmail.com on 24 Oct 2012 at 2:20

• Blocked on: #471

[GoogleCodeExporter]

7. when you close hedgewars from the window manager it will stop any encoding 
without the warning prompt

Original comment by vittorio...@gmail.com on 24 Oct 2012 at 2:34

[GoogleCodeExporter]

WRT (3)  I think that should be 30fps - 60 is awfully high for video, and 30 
should still be synced.

8.  Sound quality for webm+libvpx+vorbis - not sure if this is webm container 
only, or if all vorbis quality is horrible.  Haven't tested other combos yet.

Original comment by kyberneticist@gmail.com on 25 Oct 2012 at 3:41

[GoogleCodeExporter]

Original comment by vittorio...@gmail.com on 28 Oct 2012 at 3:35

[GoogleCodeExporter]

#1 rbfbc6aa87b7c
#2 ra691fd5f98f8
#3 r2edc88e9fcd6
#6 r2edc88e9fcd6

Updated list:
4. could prompt a warning when framerate is non standard (or use a combobox)
5. the video recording options should stay in their own tab in the setting page
7. when you close hedgewars from the window manager it will stop any encoding 
without the warning prompt
8. Sound quality for webm+libvpx+vorbis

Original comment by vittorio...@gmail.com on 28 Oct 2012 at 11:39

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I couldn't run game on Windows. Frontend starts but it says "Unable to run 
engine, Error code: 1". So I couldn't test it now.

If user will rename video file then its name will change but preview name will 
stay the same. When deleting preview you are using VideoItem::name but you 
should use VideoItem::prefix instead to handle this case. I didn't add 
automatical removing of previews because user can copy file and there will be 
two videos with same preview.

Also I think that using bitrate parameter is inefficient, quality should be 
used instead. Problem is that there is inconsistency in ffmpeg: for some codecs 
greater quality is better, for some it is opposite and some codecs doesn't 
support quality at all.

Original comment by stepik-...@mail.ru on 29 Oct 2012 at 6:55

[GoogleCodeExporter]

Quality parameter was set before, and, possibly due to inaccurate range (0-9? 
0-100?) or just broken implementation, or, who knows, maybe quality applied 
inconsistently in avcodec, but basically the webm video quality, and I tested a 
few values, was hideous.  Was as low a quality as could be imagined. Could 
barely make out what the images were.
Completely broken.
In fact, I think quality should be removed for audio too.  Since right now 
webm+vpx+vorbis (what youtube uses for html5 video) sounds like shouting down a 
rusty drain pipe.

Quality is a nice idea, but appears to be implemented completely inconsistently.
Unless the brokenness is fixed in either libavcodec or wrapper, it is useless.

Original comment by kyberneticist@gmail.com on 29 Oct 2012 at 7:48

[GoogleCodeExporter]

r3ac3ff6c7c4f takes into consideration Stepan's comments, thanks for the heads 
up. I wouldn't be too worried about users messing with the temp dir, we can 
assume they know what they are doing (right?)

I'm a bit worried about what you mentioned, can you try running engine as soon 
as possible, as we are really close to beta?

also, by quality you mean qp values?

Original comment by vittorio...@gmail.com on 29 Oct 2012 at 11:10

[GoogleCodeExporter]

9. typos in libav_interaction name
10. when recording engine starts, frontend should regain focus, or mouse will 
be trapped in the invisible window (at least on osx)

Original comment by vittorio...@gmail.com on 30 Oct 2012 at 1:25

[GoogleCodeExporter]

11. (reported by szczur) when you cancel a youtube upload, the dialog remains 
open and if you press cancel again frontend segafults

Original comment by vittorio...@gmail.com on 30 Oct 2012 at 1:27

[GoogleCodeExporter]

#9 r5e7c0810f365

Updated list:
4. could prompt a warning when framerate is non standard (or use a combobox)
5. the video recording options should stay in their own tab in the setting page
7. when you close hedgewars from the window manager it will stop any encoding 
without the warning prompt
8. Sound quality for webm+libvpx+vorbis
10. when recording engine starts, frontend should regain focus, or mouse will 
be trapped in the invisible window (at least on osx)
11. (reported by szczur) when you cancel a youtube upload, the dialog remains 
open and if you press cancel again frontend segafults

Original comment by vittorio...@gmail.com on 30 Oct 2012 at 11:50

[GoogleCodeExporter]

I can reproduce #11 in release

Original comment by vittorio...@gmail.com on 1 Nov 2012 at 2:30

[GoogleCodeExporter]

12. you can press 'r' and get the recording widget in engine even when VIDEOREC 
is disalbed (http://hedgewars.org/node/4099)

Original comment by vittorio...@gmail.com on 2 Nov 2012 at 3:12

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

#4 r1c3739ba43520ec4710a1668bb224ec05719345d
#5 r9f0e79ab51f00f3b1e133ae70cdd63f6963439c0
#7 I'm not sure there is anything we could (or should) do
#8 discovered a broken implementation in ffmpeg/libav
#11 moved to issue 471
#12 is a misunderstood report, rf3ba33d5d2b15087dd8c3c4cb4fd4a4d1d6c582f 
addresses a related problem (sorta)

Updated list:
10. when recording engine starts, frontend should regain focus, or mouse will 
be trapped in the invisible window (at least on osx)

Original comment by vittorio...@gmail.com on 18 Jan 2013 at 4:41

• Now blocked on: #471

[GoogleCodeExporter]

(given better title)
for now happens only on OSX

Original comment by vittorio...@gmail.com on 2 Mar 2013 at 12:00

• Changed title: when recording starts, mouse is trapped in a invisible window
• Added labels: OpSys-OSX, Priority-Low
• Removed labels: OpSys-All, Priority-Medium