search

EchoLiao / hedgewars

Automatically exported from code.google.com/p/hedgewars
GNU General Public License v2.0
0 stars 0 forks source link

Restore ready toggle for room admins #432

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Download brand new 0.9.18 pre-release
2. Create a room on the official server
3. You cannot un-lamp

What is the expected output? What do you see instead?
Room admin can un-lamp, like in 0.9.17.
This was a really useful indicator. AFK, blinking the lamp to slowpokes, etc.

What version of the product are you using? On what operating system?
0.9.18-7740-4ba77e6178cd / win32

Please provide any additional information below.
0.9.17: http://img.vos.uz/xnqifc.jpg
vs
0.9.18-7740: http://img.vos.uz/r86fk9f.jpg

Original issue reported on code.google.com by v...@vos.uz on 26 Oct 2012 at 6:47

GoogleCodeExporter commented 9 years ago 
This was deliberate, and koda's idea.
Inclined to close WONTFIX.  Will just turn it into an enhancemenet for debate 
and assign to him.

Original comment by kyberneticist@gmail.com on 26 Oct 2012 at 1:36

GoogleCodeExporter commented 9 years ago

Original comment by kyberneticist@gmail.com on 26 Oct 2012 at 1:37

GoogleCodeExporter commented 9 years ago 
yes a few people mentioned that they'd like the button back, so we could just 
restore it and set it ready by default for the admin only

Original comment by vittorio...@gmail.com on 26 Oct 2012 at 2:46

GoogleCodeExporter commented 9 years ago 
Huh, I have already made a change to game server to keep room admin always 
ready r835ad028fb66

Original comment by unC0Rr on 26 Oct 2012 at 8:43

GoogleCodeExporter commented 9 years ago 
fixed in re70c633ed833, please report any additional feedback you have

Original comment by vittorio...@gmail.com on 28 Oct 2012 at 3:48

GoogleCodeExporter commented 9 years ago 
Seems like the button was returned in .18 RC (0.9.18-7918), but the server 
still ignores toggles from room admin, so room admins still can't un-lamp, 
which is sad. The old behavior was useful and i see no reason why it should be 
thrown away

Original comment by v...@vos.uz on 30 Oct 2012 at 4:21

GoogleCodeExporter commented 9 years ago

Original comment by vittorio...@gmail.com on 30 Oct 2012 at 4:45

GoogleCodeExporter commented 9 years ago 
In the end, the core problem is just that the lamp doesn't stand out a lot, 
therefor people forget about it often.
Maybe a big "NOT Ready"\"Ready!" toggle button under the team-adding list or 
something in those lines would likely be more effective.
AoE2 for example has a countdown *with sound*, which the room admin can stop at 
any time, that makes the ready-lamps obsolete. The interested-in-joining 
players usually add their teams in the first 3 seconds anyway.

Original comment by inufa...@gmail.com on 30 Oct 2012 at 5:12

GoogleCodeExporter commented 9 years ago

Original comment by vittorio...@gmail.com on 25 Mar 2013 at 1:56

GoogleCodeExporter commented 9 years ago

Original comment by vittorio...@gmail.com on 25 Mar 2013 at 2:05

GoogleCodeExporter commented 9 years ago 
So to recap, currently setting ready for room owner is always on, and this is 
not good. The tradeoff is to set it ready by default when room is created and 
then leave the decision to the users.

unC0Rr, can you please change the server behaviour like this?

Original comment by vittorio...@gmail.com on 21 Apr 2013 at 3:28

GoogleCodeExporter commented 9 years ago 
Okay

Original comment by unC0Rr on 21 Apr 2013 at 5:58

GoogleCodeExporter commented 9 years ago 
ra25e18295959

Original comment by unC0Rr on 13 May 2013 at 6:50