EchoRLiu / robustGarch

robGarch package - GSoC 2020 Project - The R Project for Statistical Computing
https://summerofcode.withgoogle.com/projects/#5730856687108096
Other
1 stars 0 forks source link

fix `rtn.rda` type and documentation #18

Closed dan9401 closed 3 months ago

dan9401 commented 3 months ago

I'm in the process of updating documentation regarding #17 , and encountered a roxygen issue due to the GSPC dataset name.

In short, the loaded object name by data(rtn) needs to be the same name as last line in data.R.

I would suggest to create a branch from 17-change-class-name-to-robustgarch (d1b80de) to finish this and merge it back to 17-change-class-name-to-robustgarch.

EchoRLiu commented 3 months ago

a small idea: should we update the data with the most current data? perhaps with more years? currently it is around 13 years

dan9401 commented 3 months ago

Good point, let's do that, how did you source it last time?