search

EchterAlsFake / Porn_Fetch

Cross-Platform Porn (Hub) downloader with Account Login and Searching support
GNU General Public License v3.0
111 stars 22 forks source link

Unsupported Distribution notice on Arch-based distros #46

Closed omar-st closed 1 month ago

omar-st commented 1 month ago

Currently the installer gives a notification of "unsupported distribution" on EndeavourOS (which I use) based on the operating system name being "endeavouros" instead of "arch linux". However, this software would definitely also build successfully on other Arch-based distros.

My suggestion is that it case match the names of EndeavourOS, Manjaro, Garuda, and any other common Arch-based distros to be "arch linux". This is probably also the case for Ubuntu-based distros (Kubuntu, Mint, PopOS, etc), and other distros where the upstream is supported but downstream uses a different host name.

I can confirm that the repo builds fine on a vanilla arch VM, so I know it would also work on my EndeavourOS machine. Fundamentally, I think the best solution is not to query if the OS is named "arch linux" but to query if the package manager is pacman, but just case matching the distro name would resolve my issue.

EchterAlsFake commented 1 month ago

Thanks, I'll fix that on Sunday

omar-st commented 1 month ago

Thank you, I'll look out for it :)

omar-st commented 1 month ago

Hi, I wanted to check if there are any changes relating to this?

EchterAlsFake commented 1 month ago

(See my comment on your Pull request)

omar-st commented 1 month ago

Thanks! I think the recent merges fully resolve the issue I had.