EchterAlsFake / Porn_Fetch

Cross-Platform Porn (Hub) downloader with Account Login and Searching support
GNU General Public License v3.0
136 stars 22 forks source link

Error downloading model videos #53

Open AsunaYuuki16 opened 2 months ago

AsunaYuuki16 commented 2 months ago

It fails and aborts after a few videos. issue log.log

Edit: Not just model, downloading any video causes an error.

[Converting: 100/100WARNING:phub.core:Call failed: ConnectError('[Errno 104] Connection reset by peer'). Retrying (attempt 1/4) ERROR:phub.objects.video:Couldn't fetch the Image using HTML scraping

This is the error that comes up.

PS: please add detailed installation guide as some releases are not being installed directly. (especially the linux ones)

EchterAlsFake commented 2 months ago

Hi,

Thanks for your report. There are a few questions which I have:

If you don't want to tell about the first because of Privacy, it's totally fine.

The error with the image is currently some kind of expected or at least I know about it, and I'll fix it.

I will also test the ffmpeg downloading as soon as I am home :)

AsunaYuuki16 commented 2 months ago

Update: Downloading individual files works perfectly. It shows the error in downloading multiple files, whether it is model or file containing links. also could not find a way for the folders to work. (might be im not getting how to use it, but just reporting)

To answer your question, 1) I dont use any vpn so pretty sure not censored in my country 2) Ive tried both high performance and FFmpeg (im guessing high performance is threaded), that just fails instantly

Tried on windows 11 pro v 23H2: Uploading single file works , cli and gui work, model link gets links but on clicking download it aborts after a few downloads, uploading a file instanlty aborts

tried on kali linux: uploading single file works, couldnt use gui as i use linux in headless mode

QOL suggestion: the settings page in the CLI is a bit confusing due to the random colors. A tick or confirmation for selected options would be helpful.

Edit: One more thing idk if it is relevant or not, but after clicking download, it always says failed, HTML scraping failed or smtg like that.

EchterAlsFake commented 2 months ago

Thanks for your information. I'll fix it as soon as I can.

And I see what I can do to the settings page xD

AsunaYuuki16 commented 1 month ago

Hi, still facing this issue. Can it be related to multi threading or something similar, as whenever more than a few videos are kept for download (.txt or model or for that matter any batch option), the first few are downloaded and then the rest just throw the error and abort. Uploading the .txt file does not help as it shows invalid url (this url works if i put the same one directly in the url box)

EchterAlsFake commented 1 month ago

Hi, sorry for letting you wait so long. I haven't looked into it yet and I won't be able to in the next week (probably). Thanks for the information.

Yes it could indeed be related to multi threading, although I need to test it on my system first, to reproduce the issue.

Did you change the semaphore in the settings? Like how many videos can be downloaded at the same time? I am not sure, but the default value should be 2 or 3 and I never changed that, so if you did, then it would be good to know, so that I can test with the same conditions.

EchterAlsFake commented 2 weeks ago

Alright, so after two months I am finally back in coding, so I can now fix your case.

You said "Uploading the .txt file does not help as it shows invalid url (this url works if i put the same one directly in the url box)". Can I see an example URL where it fails, becaus this would mean, that I need to update the PHUB library to also accept such URL schemes?

You also said "Can it be related to multi threading or something similar, as whenever more than a few videos are kept for download (.txt or model or for that matter any batch option), the first few are downloaded and then the rest just throw the error and abort."

Could you maybe upload the .txt file you were using, so that I can reproduce this issue, because I haven't got it so far.

I also have a third question which is, how many download you have enabled in the same time? It's the semaphore setting in the setting spage, which is by default 2 (or 3 I think). Did you change it or left on default?

And I have corrected the settings page in the CLI. If you want you can download the repositories code and have a look at the new settings page.

Or you can also look at this image: image

I hope this looks like you have intended me to do it :)

I am sorry that it took so long for me to respond. I hope we can fix it now :)