search

Eclectic-Sheep / sheeprl

Distributed Reinforcement Learning accelerated by Lightning Fabric
https://eclecticsheep.ai
Apache License 2.0
275 stars 26 forks source link

Bug in the in sticky attack in MineDojo wrapper #178

Closed ImKvothe closed 6 months ago

ImKvothe commented 6 months ago

I think in _convert_action of the MineDojo wrapper in line 195 it should be self._sticky_attack_counter = 0 instead of self._sticky_attack = 0, right now once it stops doing an sticky attack it won't do it again because it is setting the _sticky_attack variable instead of the counter to 0, the sticky_jump just below is done correctly.

image

michele-milesi commented 6 months ago

Hi @ImKvothe, thanks for reporting this. Yeah, you are right. I will fix this error as soon as possible. Thank you