Eclipse-Community / r3dfox

r3dfox is a modern Firefox based web browser for Windows Vista & 7. SourceForge link for downloading with older browsers. https://sourceforge.net/projects/r3dfox/
https://eclipse.cx/projects/r3dfox
Other
197 stars 7 forks source link

Problems after installing browser themes. #140

Open EDSln opened 2 months ago

EDSln commented 2 months ago

There are two problems at once, with and without Aero. With the Windows 7 Base theme with any settings, the theme is not applied to the window title bar. r3dfox-128.0.2: 2

It should be like Firefox 115 1

With Aero the theme in the window title bar is applied after disabling the "Force enable caption bar transparency" setting, but the window control buttons, Minimize, Close are missing. 3

If it's configurable in about:config, what are the settings?

K4sum1 commented 2 months ago

The issue seems to be that -moz-window-titlebar coloring is not getting overridden by the lwtheme properly. I would need to figure out where this began.

K4sum1 commented 2 months ago

I really need someone that can help me with my browser. I feel burnt out, and I don't want to do anything. I'm not sure how long I'll feel this way. It just hit me after I started to investigate the issue.

If you want to help fix it try previous releases to find the last to work, also disable r3dfox themes and styles as that seems to impact it, but I can probably easily fix it. Classic theme seems to be even more broken, so check it too. After that, if you know how to use browser toolbox, investigate why the default theme is overriding the lwtheme and see if it's potentially an easy CSS fix.

I'm going to lie down now, and not to sleep, or maybe I do end up napping idk.

EDSln commented 2 months ago

Disabling the r3dfox theme did not help. I'll look for after which version the themes broke. I'd like to help, but I'm completely clueless about CSS. :(

jonm58 commented 2 months ago

on Windows 11(have Aero Glass) Windows_11 btw,The button is just hidden.

EDSln commented 2 months ago

Checked many versions, problems vary from version to version, and depend on whether the window is expanded full screen or not, but everywhere after version 122 something doesn't work. Beta 95% branded v122.0.1-2 - no problems. Beta Aero v123.0.2 aero bug as on the screenshot below. basic in windowed mode bookmark bar without theme. Beta Aero v123.0.2-2 aero bug as on the screenshot below. basic in window mode bookmark bar without theme. 124.0.2 aero bug as on the screenshot below. basic - in window mode bookmark bar without theme. 123-124 bug aero 124.0.3 aero - no problems. basic - full screen - no problems, in window mode - no theme. Release v125.0rc aero - no problems. basic - full screen - no problems, window mode - no theme. Release v125.0rc2 aero - no problems. basic - full screen no problems, window mode - no theme. Release v125rc3 aero - no buttons. basic - full screen - no problems, window mode - bookmarks panel without theme. 125.0.3 aero - no buttons. basic - full screen no problems, window mode - no theme. 124-125 basic no theme 126.0+ aero - no buttons. basic - window title bar without theme.

jonm58 commented 2 months ago

图片 I suspect that Firefox's browser theme is at the top level, causing problems with native patch controls.

SoftwareType commented 2 months ago

on Windows 11(have Aero Glass) Windows_11 btw,The button is just hidden.

Without Aero Glass it also happens, but for some reason I suspect it is because of how Firefox handles the buttons. At default, Firefox always used their custom buttons, and, probably, those themes are trying to detect the buttons (and adjust the colors of it) but it fails

KT907 commented 2 months ago

If you disable hardware acceleration and webrender in about:config, the buttons are displayed fine in third-party themes. Presumably, in this direction you need to look for compatibility errors.

EDSln commented 2 months ago

Yes, it looks like the problem is the wrong order of layers, there are buttons under the theme. not naming

K4sum1 commented 2 months ago

https://github.com/Eclipse-Community/r3dfox/issues/59

EDSln commented 2 months ago

Wouldn't it be easier to add an option, if possible, that completely reverts the Win 10 theme? Those who have the theme installed don't see the system window title bar anyway, and the fact that the window close buttons won't be from 7 is not so terrible.

jonm58 commented 2 months ago

Wouldn't it be easier to add an option, if possible, that completely reverts the Win 10 theme? Those who have the theme installed don't see the system window title bar anyway, 和 the fact that the window close buttons won't be from 7 is not so terrible.

set widget.ev-native-controls-patch.override-win-version to 10,you can get Win 10 theme

EDSln commented 2 months ago

set widget.ev-native-controls-patch.override-win-version to 10,you can get Win 10 theme

Thanks, no problem with Aero now. 1

But the Basic theme is still without the browser theme in the window title bar. Perhaps the problem is that Win10 simply can't have a Basic theme.

K4sum1 commented 2 months ago

I can't fix this without many days of trying and probably failing to fix the cause. This is something I need external help with.