search

Eclipse-Community / r3dfox

r3dfox is a modern Firefox based web browser for Windows Vista & 7. SourceForge link for downloading with older browsers. https://sourceforge.net/projects/r3dfox/
https://eclipse.cx/projects/r3dfox
Other
236 stars 10 forks source link

cookiebanners.service.mode overrides cookie blocking settings #176

Open marty60 opened 2 months ago

marty60 commented 2 months ago

When through settings/privacy & security/custom it is checked to "All Cookies (will cause websites to break)" 128.2.0 still allows cookies. One site tested is old.reddit.com, it doesn't do it with every site but you can find the cookies in Manage Data. Also tried blocking them individually through Manage Exceptions and they still were set. Confirmed with a new profile with the same results.

K4sum1 commented 2 months ago

Can you check if stock Firefox works? I don't think any changes I've made would affect this behavior.

marty60 commented 2 months ago

None of the official Firefox versions I'm seeing this (115.15, 128esr, nightly). So far only https://old.reddit.com is doing it although msn.com does it occasionally.

K4sum1 commented 2 months ago

Can you check previous releases to see where the issue began? I'm too busy to debug this so I'll probably only get around to fixing after I release 130.

K4sum1 commented 2 months ago

This might be a bug with Firefox, but some change in both my fork and Waterfox exposes it. It's the same issue as this https://github.com/BrowserWorks/Waterfox/issues/3490

Both r3dfox and Waterfox allow cookies for Google and Reddit. I can't get MSN to load on my end, but I assume it would be the same there too.

image

K4sum1 commented 2 months ago

I remembered dev tools exists, so I took a look at the storage tab, and noticed the Reddit cookie is named eu_cookie. This made me think of something. I had traced the Waterfox issue to G6.0b3, and I looked at the changes in that version again.

cookiebanners.service.mode and cookiebanners.service.mode.privateBrowsing

G6.0b3 set these both to 2, and a bit back I also set both to 2 in r3dfox. These override the block all cookies setting and set cookies so you don't get spammed with the EU cookie prompts. I assume someone blocking all cookies would also use uBlock Origin or similar which also blocks said prompts. So I don't think it's of much use to set these if you block all cookies, but I'll leave that up to the user. I'd prefer to have them set for new users for a better user experience, so I'll leave them as is.

I'm not sure what to do here though. Should I report the bug to Mozilla since it is setting cookies even though I told it to block all? Should I make a preference for it in settings with a note about it overriding the cookies setting? Should I just leave it as is?

marty60 commented 2 months ago

With 115.15 I checked those prefs and they're set to 0 so I did the same with your version and now reddit's not setting any cookies. Maybe that's the answer, although I never even knew about that feature. I'm assuming when at 0 it's completely disabled? I've never run into noticeable problems so I'll leave it there for now and see how it goes.

K4sum1 commented 2 months ago

Not sure how to set a boolean option that would change both between 0 and 2 just yet.

K4sum1 commented 2 months ago

Edited title to be more relevant