Closed goodusername123 closed 2 months ago
I don't really have a way to test this either tbh. I don't have anything immediate I can grab or use that is 8.1 and has fully working hardware acceleration.
I guess when I finalize this release I can try applying this commit and see what happens. I can just make an 8.1 install for this on something.
Wish there was some VM software with hardware acceleration that I could test with.
Maybe VMware with this commit [functional commit for allowing VMware hardware accel on Firefox I made for another Gecko based repo] could work for testing? recent versions of VMware have pretty good hardware acceleration with support for DirectX 11 (I saw a friend play GTA 5), WDDM 1.2, and modern versions of OpenGL so theoretically Direct Composition could possibly function in that environment although I'm not 100% sure on what exactly is required for Windows to expose DComp driver wise. as for why Firefox has VMware on a blacklist by default it's because the blacklist never got updated to remove VMware after it got greatly improved hardware accel support because back in the day it only support up to DirectX 9, I mean heck even Chromium removed VMware from their blacklist.
I can't seem to get hardware acceleration working under VMware Workstation 16. I have a 2080 Ti and VMware just keeps saying hardware acceleration is not supported no matter what settings I enable or disable in the .vmx. I have no idea how to get it working. It was working fine in 12 and 14.
I realized that many people have tested Firefox latest on 8.1 since it kinda just works with subsystem modding. If this was an issue, I think it would've been seen by now. So I'm just merging this.
Also if you can help with any other issues it would be appreciated.
Also do you have a Discord?
So I shouldn't have jumped the gun.
"Blocklisted; failure code RcANGLE(no compositor window)_FIRST"
Disabling DComp fixes it. Rolling back commit.
This attempts to allow Direct Composition to be enabled in Windows 8.1 (not 8.0 since it seems to lack a required API) as by default it's forced off instead of allowing the user to choose via
gfx.webrender.dcomp-win.enabled
.Sadly I was not able to test this since I do not have the requisite setup to compile and test this change but in theory this should work fine.