search

Eclipse-Community / r3dfox

r3dfox is a modern Firefox based web browser for Windows Vista & 7. SourceForge link for downloading with older browsers. https://sourceforge.net/projects/r3dfox/
https://eclipse.cx/projects/r3dfox
Other
197 stars 7 forks source link

Caption buttons get hidden with lightweight theme with hardware acceleration enabled #59

Open K4sum1 opened 5 months ago

K4sum1 commented 5 months ago

I didn't pick this up when testing the current commits that fix lightweight themes, because I don't have a good way to easily test the browser with hardware acceleration. I can't test on my main system due to hardware incompatibility, I can't test in VMware because it doesn't want to enable 3D acceleration for no reason, and I can't test in Virtualbox because it doesn't want to work even with the commit I made.

Without hardware acceleration, the Aero fog does not cover the caption buttons, however with it enabled, it does. The same applies to lightweight themes, the theme color or image gets drawn over the buttons with hardware acceleration. Considering this is a visual issue as the buttons still work, I won't be putting too much research into it.

Potential solutions:

1: Make the cutout work with hardware acceleration.

2: Force the caption buttons to display above the image.

3: Bring back the original fix.

Not sure how to do 1 or 2.

I did some tracing, and found 3 began with https://github.com/mozilla/gecko-dev/commit/249d76638642dc052b144bf45461c5c14af46af7 in 117. The problem file is browser.js and undoing only that file for 117 fixes the issue. However this got further broken in 118, and I'm not sure what to do here. None of the future commits seem problematic. I guess I could go bisecting, but I would want to root cause the issue. I really don't want to start bisecting for this, but if enough people want it, I can.

K4sum1 commented 5 months ago

I've figured out how to get hardware acceleration in VMware Workstation 16! Maybe I can figure this out.

i486 commented 5 months ago

Since I've been daily driving redfox and also use Theme and HW, I solved this issue by choosing a theme that shows the caption buttons.

Currently using this one: https://addons.mozilla.org/en-US/firefox/addon/forest_/

Have about 60 themes installed, and only a few showed captions.

It's worth mentioning that captions are still hidden on black/dark-themed themes too, not just lightweight themes for me. A fix would be nice for theme users.

K4sum1 commented 5 months ago

Hmm, the forest looks like an image overlayed on both bars. I wonder if that is why it's fine. Maybe I could see what code handles that.

All themes on the Mozilla store are lightweight, unless you mean userChrome.css based themes, in which case those make sense to be broken too, but aren't really supported here since I have made so many changes that themes like Echelon kinda just work again.

i486 commented 5 months ago

Hmm, the forest looks like an image overlayed on both bars. I wonder if that is why it's fine. Maybe I could see what code handles that.

All themes on the Mozilla store are lightweight, unless you mean userChrome.css based themes, in which case those make sense to be broken too, but aren't really supported here since I have made so many changes that themes like Echelon kinda just work again.

English issue. I initially interpreted it as 'light,' referring to dark or light scheme themes. Now, I realize that complete themes used to be available in Firefox as well :P

K4sum1 commented 5 months ago

While trying to add an option to force enable transparency with lightweight themes, I found something interesting.

Maybe I'm looking at the wrong thing or it's a layer of issues. It seems Firefox draws the color over the caption button area separately from the caption bar or navigator-toolbox.

image

K4sum1 commented 5 months ago

So that is lwt-header-image, however with that disabled, the issue still persists.

I think the best bet is trying to figure out how this differs from with/without acceleration, and apply the cutout on both modes.

K4sum1 commented 4 months ago

So while trying to fix another problem that arose with 126, I spotted this.

/* TODO bug 1695280: Remove these media selectors and merge the rule below
   with the ruleset above. We must set background properties on :root and not
   #navigator-toolbox on Windows 7/8 due to a WebRender bug that hides the
   minimize/maximize/close buttons. */

This was part of old code that got invalidated in 120, so I just removed it all. The issue still occurs in 118, so if this is still an issue, something else further broke it in 118. I wonder why they wouldn't just fix WebRender.

https://bugzilla.mozilla.org/show_bug.cgi?id=1695280

i486 commented 4 months ago

I am still using r3df0x 125.0.3 with the Forest theme I mentioned earlier. While testing r3df0x 126, I discovered that the caption buttons no longer appear when using the Forest theme. However, they do show up if I disable hardware acceleration.

i486 commented 3 months ago

Still stuck on 125.0.3 due to 126+ regression with forest theme

K4sum1 commented 3 months ago

I don't have the time or the skill to fix this issue, sorry.

I'll keep it open for someone to fix with a pr (please)

i486 commented 3 months ago

No worries, bro.

I am upgrading to r3dfox v127.0.2 and ditch the forest theme because they finally fixed the 1440p+ youtube freezing issue. It has been torn in my ass for the last 6+ months or so.