Eclipse-Dominator / pe

0 stars 0 forks source link

Uncaught exception when opening help window with no internet connection #7

Open Eclipse-Dominator opened 1 year ago

Eclipse-Dominator commented 1 year ago

image.png

There is an uncaught exception when opening the help window when there is a sudden internet breakdown. This results in the error above and a black internet screen. It is wrong to assume that the user will always be able to use the application when there are always internet access and a warning/tip should be shown to the user if there is a lack of internet connection.

soc-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Application would not run when there are no internet connection as well as unable to view module information offline

I know this application uses the NUS API to retrieve the mods required and is necessary for them to obtain the list of module code. However, as a student I might not have access to a good internet connection or sometimes I just wanted to view the modules offline. In those instances, NUS mod website actually caches the data offline so I can still view my chosen modules even though I have no access to the internet connection. However, when trying to open your application offline, it will just hang and attempt to connect to an internet connection without giving me any errors or prompt.

image.png

Users who does not know this can be unsure of whats going on since the issue was due to a lack of response from the online API


[original: nus-cs2103-AY2223S1/pe-interim#1474] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We already mentioned that users are to connect the internet: "CLIMods requires internet access because we fetch module data from NUSModsAPI. Please ensure that you have internet access before launching CLIMods."

Read here:

image.png

The reason why you can see your modules offline is potentially because of your browser's HTTP default cache mechanism.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The original bug was a result of slow and long start up by the user when launching the application without internet connection. The bug here is when there is a break in internet connection when the user uses the application.


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Indeed the user guide has pointed out that an internet connection is required for the user to use the application, it is completely possible for users to lose internet connection (due to unstable internet) during the process of using the application. This runtime exception should be caught by the application and there should be an additional error message to inform the user that there is no internet connection to access the UG page. I think it is completely logical to require the user to have internet connection when using the application but the application should still handle the situation when there is no internet available.


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Medium] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]