EmperorArthur
commented
7 years ago Okay, I've added an emergency fix for master. Skill matching was borked because of a bad copy paste.
Since I haven't received any feedback I'm going to go ahead and merge this now.
Site Speadups
Has the creator ever seemed slow to you? Things take a while to load? Then this pull request is for you.
The creator used several off site resources. Almost[1] everything is now done using php includes, so people with laggy connections should see things load much faster.
For those brave enough to try this on mobile, your data is safe. The creator no longer tries to load muli-megabyte backgrounds every minute.
Even if you have a blazing fast connection, you'll still notice a difference. Why? Because we no longer show a loading indicator for 3 seconds, even after the page has finished loading. This change alone makes the page seem that much more responsive, even though it's a minor visual tweak.
Another change is the removal of the browser compatibility images. I'm not manually checking all browsers, and there's so much javascript that automated testing is nearly impossible. Plus, that was over 1MB of images being loaded, and then shrunk by the browser. For comparison, index.php with everything, including some images, embedded is only 500KB.
Documentation
We now have some.
While it's extremely minor, this helps explain what is going on with some parts of the program. It gives some important information regarding item sizes. You no longer have to dig through CSS files, since I've done it for you!
Other
Help text now comes in tooltip form. Just hover over a help button to get handy dandy help information. It's also instant, since it's created at page load instead of using ajax. This completely removes the drop down slide. It was annoying, never really fit the UI style of the rest of the page, and didn't work on mobile at all.
CSS cleanup is still a major chore and is proceeding apace.
git now ignores more files. This isn't a cleanup the end users will see, but developers will be happy to know they are less likely to accidentally include something.
Popup loading has been reworked. It can still be made a bit more generic, but it's now possible to add popups on the fly. Without having to edit index.php.
Conclusion
This pull focuses on loading speed and UI cleanups. End users should notice both the speed difference, and the tooltip help buttons. Everything else is just paring down code redundancies and getting it in a format that I can understand.
As always, feedback is welcome. If no one has a problem, this pull will be merged in a couple of days.
[1] Fonts and backgrounds are loaded from off site. Most images require a separate connection to the server.