Eclipse-Station / NEV-Northern-Light

Congratulations, [employee name here]! You have greatly advanced the expedition effort. You must be the pride of [employee hometown name here]! NanoTrasen commends your usefulness to the Corporation.
https://discord.gg/xuS4t9U
Other
8 stars 54 forks source link

Cryoing doesn't remove people from the crew manifest. #317

Open EvilJackCarver opened 4 years ago

EvilJackCarver commented 4 years ago

Cryoing out of a round doesn't remove names from the crew manifest. This can cause issues where more than one Chief Medical Officer shows on the manifest (including the online manifest).

Impact: I-2 Most players Severity: S-5+ Trivial

EvilJackCarver commented 3 years ago

The issue with the crew manifest appears to be solved, however the online manifest still has this issue. In addition, the online manifest does not list church members.

YoteSanity commented 3 years ago

I can speak to why the latter issue occurs. If you take a look at .../manifest/manifest/status.php while a Church member is on, you'll see that they're in the JSON the web manifest pulls from, and that they're under the "chr" department label. In .../manifest/manifest/byondstatus.js, you see the following array of departments recognized by the manifest:

const DEPARTMENTS = {
    "heads" : "Heads",
    "sec" : "Security",
    "eng" : "Engineering",
    "med" : "Medical",
    "sci" : "Science",
    "car" : "Cargo",
    "civ" : "Civilian",
    "bot" : "Silicon",
    "misc" : "Miscellaneous"
};

Fixing the issue with the web manifest not listing Church members should be as simple as adding a "chr" : "Church" element that's missing from the array. I don't think this falls within the scope of the Git repo and think it will have to be fixed on Nestor's end.

EDIT: Managed to snag the manifest in the status JSON while a Church member was on:

    "manifest": {
        "misc": {
            "Will BlackCroft": "Union Artist"
        },
        "civ": {
            "EC-HO": "Club Worker",
            "Madelyn King": "Deckhand"
        },
        "chr": {
            "Hrungnir": "Mekhane Custodian"
        }
    },
EvilJackCarver commented 3 years ago

The issue appears to have regressed to the point where players are once again no longer removed from the online crew manifest.