search

EclipseFdn / asciidoc-wg.eclipse.org

The AsciiDoc Working Group drives the standardization, adoption, and evolution of AsciiDoc. This group encourages and shapes the open, collaborative development of the AsciiDoc language and its processors.
https://asciidoc-wg.eclipse.org/
Eclipse Public License 2.0
3 stars 10 forks source link

Add Eclipse Austen project #64

Closed abelsromero closed 3 years ago

abelsromero commented 3 years ago

Closes #61

abelsromero commented 3 years ago

Stupid question...I wanted to add an option to add Code repo button next to the Website button, but couldn't find where the labels are defined, not even search for the labels "Website" or "Download" :open_mouth:

autumnfound commented 3 years ago

Stupid question...I wanted to add an option to add Code repo button next to the Website button, but couldn't find where the labels are defined, not even search for the labels "Website" or "Download"

This is created from a layout file in the base theme for projects seen here: https://github.com/EclipseFdn/hugo-solstice-theme/blob/master/layouts/projects/summary.html. If you wanted to add a code repo button, you could probably make a pull request to add it (with some checking to only print it when we have it). It can be tricky to find so I don't blame you!

abelsromero commented 3 years ago

This is created from a layout file in the base theme for projects seen here: https://github.com/EclipseFdn/hugo-solstice-theme/blob/master/layouts/projects/summary.html. If you wanted to add a code repo button, you could probably make a pull request to add it (with some checking to only print it when we have it). It can be tricky to find so I don't blame you!

That's not the issue, the thing is where do the literals come from? I was expecting this {{ i18n "project-summary-website-label" }} to point to some property/json/yaml with that key but could not find it, even searching by "Website" which the value did not bring results.

autumnfound commented 3 years ago

This is created from a layout file in the base theme for projects seen here: https://github.com/EclipseFdn/hugo-solstice-theme/blob/master/layouts/projects/summary.html. If you wanted to add a code repo button, you could probably make a pull request to add it (with some checking to only print it when we have it). It can be tricky to find so I don't blame you!

That's not the issue, the thing is where do the literals come from? I was expecting this {{ i18n "project-summary-website-label" }} to point to some property/json/yaml with that key but could not find it, even searching by "Website" which the value did not bring results.

Ahh! Gotcha. i18n labels are stored in the i18n folder in the root of the project, in line with whats defined on the Hugo documentation for i18n. That particular value is set in the following file: https://github.com/EclipseFdn/hugo-solstice-theme/blob/master/i18n/en.toml#L208

ahus1 commented 3 years ago

@abelsromero - I see you link to the project proposal. AFAIK this page is immutable once the project is created.

The project page is: https://projects.eclipse.org/projects/technology.austen

The biggest difference: The project page contains the Git repo link, while the project proposal doesn't.

Therefore I suggest: please update the URL to point at the project page.

abelsromero commented 3 years ago

refore I suggest: please update the URL to point at the project page.

Fixed, many thanks for the verification