Investigate Strongloop eslint config

[autumnfound]

In a recent patch, ESLint was added to provide better assurance of quality while building and running the script. To more quickly configure it, a configuration set was used to quickstart the linting configuration. The configuration should be more thoroughly checked to ensure that it meets our quality standards and conventions.

[autumnfound]

Looking into the Strongloop configuration, there is a mix of stylistic rule activations and some additional restrictions around some good practices in the node JS and ECMA.

Additionally, I've added the following rules:

• complexity: Cyclomatic complexity in methods. This will push us to better break down methods to not be overly complex.
• default last param: Forces optional/default params to be last in the list of params. This allows them to not be included in the method signature if not needed.
• no magic numbers: Magic numbers are inline numbers that are not variables. These typically should have more information and documentation to explain what they represent, and if used multiple times, be easily maintained if they ever need to be changed.

Suggested final configuation:

{
    "extends": [
    "eslint:recommended",
        "strongloop"
    ],
    "env": {
        "node": true,
        "es2017": true,
        "browser": false
    },
    "parser": "babel-eslint",
    "ignorePatterns": [
        "test/*.js",
        "**/vendor/*.js"
    ],
    "rules": {
        "max-len": [1, 140, 2],
        "eqeqeq": 1,
        "complexity": [
            "error"
        ],
        "default-param-last": [
            "error"
        ],
        "no-magic-numbers": [
            "error",
            {
                "ignore": [-1, 0],
                "ignoreArrayIndexes": true
            }
        ],
        "arrow-parens": [
            "error",
            "as-needed"
        ]
    }
}