search

EclipseFdn / openadx.eclipse.org

OpenADx is about an ecosystem. Each company/partner brings its specialized expertise into one or more of the ecosystem topic areas helping to create the most efficient tool chain possible and improve that toolchain over time.
https://openadx.eclipse.org/
Eclipse Public License 2.0
3 stars 16 forks source link

Updates March2021 #134

Closed ariexi closed 3 years ago

ariexi commented 3 years ago

Signed-off-by: ariexi andreas.riexinger@de.bosch.com

Some necessary updates

netlify[bot] commented 3 years ago

Deploy preview for eclipsefdn-openadx ready!

Built with commit 355691d8f679a26ff4da6d3f4912464a96738faa

https://deploy-preview-134--eclipsefdn-openadx.netlify.app

ariexi commented 3 years ago

@autumnfound, any idea on how to integrate twitter timelines and twitter buttons? Thx! Andy

ariexi commented 3 years ago

@autumnfound, any idea on how to integrate twitter timelines and twitter buttons? Thx! Andy

@autumnfound, did you had the chance to have a look on my PR? ;-) Thx!

autumnfound commented 3 years ago

@autumnfound, any idea on how to integrate twitter timelines and twitter buttons? Thx! Andy

@autumnfound, did you had the chance to have a look on my PR? ;-) Thx!

Looking at your attempts for timeline, I don't know why it wouldn't have worked...it looks pretty straightforward tbh. The button is just a reskin of how they do the timelines, so get that working and this one would be a piece of cake. I'm finishing some stuff up today, but I'll see if I can get this working today in a separate patch!

autumnfound commented 3 years ago

Apologies for not merging, I hadn't realized you had removed the Twitter things originally, and then we hit end of quarter which was pretty busy for us. I looked it over again and it all looks good so I merged it! I think we need to look at Twitter stuff as a whole in the base theme, as it could be a useful addition!

autumnfound commented 3 years ago

Here's the issue for tracking: https://github.com/EclipseFdn/hugo-solstice-theme/issues/218