search

EclipseFdn / solstice-assets

Assets for the Eclipse Foundation look and feel called Solstice.
https://eclipsefdn-solstice-assets.netlify.app/
Eclipse Public License 2.0
1 stars 13 forks source link

remove membership list from main js #274

Open chrisguindon opened 3 years ago

chrisguindon commented 3 years ago

Signed-off-by: Christopher Guindon chris.guindon@eclipse-foundation.org

netlify[bot] commented 3 years ago

✔️ Deploy Preview for eclipsefdn-solstice-assets ready!

🔨 Explore the source changes: e82edc31d8442e617770706af2468aa15db47242

🔍 Inspect the deploy log: https://app.netlify.com/sites/eclipsefdn-solstice-assets/deploys/61268f41903e4c0007fbb05e

😎 Browse the preview: https://deploy-preview-274--eclipsefdn-solstice-assets.netlify.app

chrisguindon commented 3 years ago

This allows us to save ~60kb for the main.js file. However, the moment that we decide to use 'isomorphic-fetch' in a "core" file, saving drops to 10kb.

A core file here is simply a file that we include in our main.js which we have on all of our sites.

chrisguindon commented 3 years ago

Converting to draft as I am not sure the trade-off is worth it.