bug in plotting DBH trends at CB

EcoClimLab / ForestGEO-tree-rings

Repository for analysis of tree-ring data from 10 globally distributed forests (Anderson-Teixeira et al., in press, Global Change Biology)

2 stars 2 forks source link

bug in plotting DBH trends at CB #140

Closed teixeirak closed 3 years ago

teixeirak commented 3 years ago

@ValentineHerr , I've found another bug while working on the summary figure:

For PIEN at CB, there are significant first- and 2nd-order effects of DBH in both models with and without year (identical, as year is not in best model):

This gives this curve:

This does not match what's plotted in either models with year (because it's a dashed line, indicating that 2nd order is non-sig)... (PIEN in yellow)

or the model without year:

Same thing seems to be going on with ABBI (red in plots above). I'm not sure about other species.

teixeirak commented 3 years ago

Also, for PIEN, significant climate effects are plotted as non-sig.

ValentineHerr commented 3 years ago

Hmmm yes, I see the solid/dashed/towdashed lines have all been mixed up. I'll fix this now... sorry for that and thanks for catching it!

ValentineHerr commented 3 years ago

I pushed something but I don't think it is right yet (I think it messed those linetypes up even more).... will push new updates once everything has run again.

ValentineHerr commented 3 years ago

I think the figures are good to go now. Let me know if you see more issues.

teixeirak commented 3 years ago

Thanks, @ValentineHerr !