EcoClimLab / vertical-thermal-review

Manuscript and new analysis files for Vinod et al., 2022, New Phytologist
Creative Commons Attribution 4.0 International
0 stars 0 forks source link

make editable versions of Figures 2-4 #127

Closed teixeirak closed 1 year ago

teixeirak commented 1 year ago

@NidhiVinod , @mcgregorian1 , @ValentineHerr , The journal requested editable versions of Figs. 2-4 (NEON height profiles, tealeaves figure, and tree-rings figure). We've been through this with a couple Nature papers, and Valentine knows what to do.

Valentine, could you please make an editable version of the tree-rings figure that you previously produced, and also copy the bit of R code here so that Nidhi and Ian know how to edit the figures they produced?

ValentineHerr commented 1 year ago

Looking into this now:

This is what needs to happen:

In the code, you need to remove your statements before you plot the figure so the figure appears in your plotting device and replace dev.off() by dev.copy2pdf(file="Figurename.pdf", useDingbats=FALSE, family="serif", width = 7.2, height = 8)

ValentineHerr commented 1 year ago

I pushed an editable pdf of the tree ring figure.

teixeirak commented 1 year ago

Thanks so much!

NidhiVinod commented 1 year ago

Looking into this now:

This is what needs to happen:

In the code, you need to remove your statements before you plot the figure so the figure appears in your plotting device and replace dev.off() by dev.copy2pdf(file="Figurename.pdf", useDingbats=FALSE, family="serif", width = 7.2, height = 8)

@ValentineHerr, thank you so much for sharing the code! I'm confused, do I enter dev.copy2pdf(file="Figurename.pdf", useDingbats=FALSE, family="serif", width = 7.2, height = 8) before the plotting code? and then have the code underneath it?

ValentineHerr commented 1 year ago

no after, and make sure to update the file name but leave it as a pdf (and you may need to adjust the width and height

teixeirak commented 1 year ago

@mcgregorian1 just told me he's not feeling well and may not be able to get to this for awhile. Nidhi, perhaps you can make this tweak in his code and run it to produce the new figure?

NidhiVinod commented 1 year ago

Oh, hope Ian feels better! Seems like it should be do-able! I'll work on it today.

NidhiVinod commented 1 year ago

@teixeirak, shoot, I'm getting an error with the code, but not sure where the error is from

Screen Shot 2022-09-30 at 9 21 43 AM
NidhiVinod commented 1 year ago

dev.copy2pdf(file="Figurename.pdf", useDingbats=FALSE, family="serif", width = 7.2, height = 8)

I fixed this error, but now I'm getting this:

Screen Shot 2022-09-30 at 9 43 13 AM

@ValentineHerr, would you know why this would be?

ValentineHerr commented 1 year ago

Hi @NidhiVinod, are you running this line of code after the plot shows up in RStudio?

To make sure all is set, run dev.off() a few times in a row, until it throws you an error (this should close all the open plotting devices you may have), then run the code necessary to plot the figure, it should show up in R studio (so make sure there is no line of code that is, e.g. pdf() or png() or jpeg() before your plot code). Once you can see your figure within RStudio, run the dev.copy2pdf(...).

If you still have an issue, try restarting R and try again.

If all fails, indicate the script and line of code you are working on and I'll try it myself.

NidhiVinod commented 1 year ago

@ValentineHerr, thank you so much! That worked!

NidhiVinod commented 1 year ago

@teixeirak, I was able to make Figure 2 and 3 editable through R, but the only thing is for Figure 3, I had made a few manual edits to make the table symbols subscripts for Gs and Tair etc... Do you know if the illustrator can do that?

teixeirak commented 1 year ago

I'd assume so. I'd sent it to them with a note.

You got the version of Fig. 4 that Valentine made, correct?

ValentineHerr commented 1 year ago

You could try to do the same for that figure and edit it in PDF to make the subscripts.

Get Outlook for iOShttps://aka.ms/o0ukef


From: Nidhi Vinod @.> Sent: Friday, September 30, 2022 3:41:15 PM To: EcoClimLab/vertical-thermal-review @.> Cc: Herrmann, Valentine @.>; Mention @.> Subject: Re: [EcoClimLab/vertical-thermal-review] make editable versions of Figures 2-4 (Issue #127)

External Email - Exercise Caution

@teixeirakhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fteixeirak&data=05%7C01%7Cherrmannv%40si.edu%7C32e5a804888a44b2f98308daa31bbd5b%7C989b5e2a14e44efe93b78cdd5fc5d11c%7C0%7C0%7C638001636774396833%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MClkgHrnb0A0aKfvKIsBqQCVSvlbmCrhhmlF39Wf8vM%3D&reserved=0, I was able to make Figure 2 and 3 editable through R, but the only thing is for Figure 3, I had made a few manual edits to make the table symbols subscripts for Gs and Tair etc... Do you know if the illustrator can do that?

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FEcoClimLab%2Fvertical-thermal-review%2Fissues%2F127%23issuecomment-1263951865&data=05%7C01%7Cherrmannv%40si.edu%7C32e5a804888a44b2f98308daa31bbd5b%7C989b5e2a14e44efe93b78cdd5fc5d11c%7C0%7C0%7C638001636774396833%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=CdLxW93Sqrg%2FTGZTgTYffhXPnXKErTk0SwrtujVT36E%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEWDCIORXBKAPEWBUJRGGADWA465XANCNFSM6AAAAAAQX7BVN4&data=05%7C01%7Cherrmannv%40si.edu%7C32e5a804888a44b2f98308daa31bbd5b%7C989b5e2a14e44efe93b78cdd5fc5d11c%7C0%7C0%7C638001636774396833%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=PbeFbjmmwkQQQns6rNJ1BB%2BxeA%2BgdCxhci12rvv90RM%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

NidhiVinod commented 1 year ago

I'd assume so. I'd sent it to them with a note.

You got the version of Fig. 4 that Valentine made, correct?

Great! Yes, is it the one in Figures folder Valentine?

NidhiVinod commented 1 year ago

You could try to do the same for that figure and edit it in PDF to make the subscripts. Get Outlook for iOShttps://aka.ms/o0ukef ____ From: Nidhi Vinod @.> Sent: Friday, September 30, 2022 3:41:15 PM To: EcoClimLab/vertical-thermal-review @.> Cc: Herrmann, Valentine @.>; Mention @.> Subject: Re: [EcoClimLab/vertical-thermal-review] make editable versions of Figures 2-4 (Issue #127) External Email - Exercise Caution @teixeirakhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fteixeirak&data=05%7C01%7Cherrmannv%40si.edu%7C32e5a804888a44b2f98308daa31bbd5b%7C989b5e2a14e44efe93b78cdd5fc5d11c%7C0%7C0%7C638001636774396833%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MClkgHrnb0A0aKfvKIsBqQCVSvlbmCrhhmlF39Wf8vM%3D&reserved=0, I was able to make Figure 2 and 3 editable through R, but the only thing is for Figure 3, I had made a few manual edits to make the table symbols subscripts for Gs and Tair etc... Do you know if the illustrator can do that? — Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FEcoClimLab%2Fvertical-thermal-review%2Fissues%2F127%23issuecomment-1263951865&data=05%7C01%7Cherrmannv%40si.edu%7C32e5a804888a44b2f98308daa31bbd5b%7C989b5e2a14e44efe93b78cdd5fc5d11c%7C0%7C0%7C638001636774396833%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=CdLxW93Sqrg%2FTGZTgTYffhXPnXKErTk0SwrtujVT36E%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEWDCIORXBKAPEWBUJRGGADWA465XANCNFSM6AAAAAAQX7BVN4&data=05%7C01%7Cherrmannv%40si.edu%7C32e5a804888a44b2f98308daa31bbd5b%7C989b5e2a14e44efe93b78cdd5fc5d11c%7C0%7C0%7C638001636774396833%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=PbeFbjmmwkQQQns6rNJ1BB%2BxeA%2BgdCxhci12rvv90RM%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

I have to somehow cut or remove the words that are there in the Tleaf table and replace it with new text along with subscript. I can't figure out how to cut the words or write it over with the same matching background color :(

teixeirak commented 1 year ago

I'd recommend you just send what you have to the journal with an explanation of what needs to happen.

ValentineHerr commented 1 year ago

I'd assume so. I'd sent it to them with a note. You got the version of Fig. 4 that Valentine made, correct?

Great! Yes, is it the one in Figures folder Valentine?

yes