EcoClimLab / vertical-thermal-review

Manuscript and new analysis files for Vinod et al., 2022, New Phytologist
Creative Commons Attribution 4.0 International
0 stars 0 forks source link

check that nocite references are working #55

Closed teixeirak closed 3 years ago

teixeirak commented 3 years ago

I just discovered that it seems there can only be one "nocite" section in an .Rmd, and a 2nd will override the first so that the references don't appear. We have a nocite section for each table, so need to check/ fix this.

teixeirak commented 3 years ago

@NidhiVinod , you could also look at this if you have time.

NidhiVinod commented 3 years ago

@teixeirak, could we merge the citations, nocite, from the 2 tables into just one?

teixeirak commented 3 years ago

Yes, we want just one nocite section. It's an easy fix... and then spot check to make sure the references are making it in. I also noticed that .Rmd doesn't display warnings when a citation key in the nocite section fails, so you have to be sure they're all correct, or double check that they all make it into the citations section of the knit document.

NidhiVinod commented 3 years ago

I combined the two nocite sections into one, but for some reason nocite is not citing any of the references, and I can't yet figure out why

NidhiVinod commented 3 years ago

okay, figured it out. I think all the citations are included in the references now!

teixeirak commented 3 years ago

Great! I didn't see your second comment at first and was trying to play with it, and in the meantime discovered that there are a few missing citations within that set:

image

There also seem to be some duplicates (e.g., Carter).

This paper sure has a lot of citations!

teixeirak commented 3 years ago

Also, please confirm that I didn't mess this up when I merged my conflicted version (citing SI items). I think it should be fine.

NidhiVinod commented 3 years ago

I fixed the citations above and took out some duplicates. I am yet to fix chitra-tarak's citation, will get back to this in a bit

teixeirak commented 3 years ago

@NidhiVinod , closing this because the problem is solved. We obviously still have a bit of references cleanup left, but don't need an issue for that.