search

EcoClimLab / vertical-thermal-review

Manuscript and new analysis files for Vinod et al., 2022, New Phytologist
Creative Commons Attribution 4.0 International
0 stars 0 forks source link

in Tleaf figure, refer to "humid" (rather than "normal") and "drought" conditions #64

Closed teixeirak closed 3 years ago

teixeirak commented 3 years ago

@NidhiVinod , I think it's better to refer to "humid" rather than "normal" conditions, especially because you used mean max humidity. Even if these parameters truly represent normal conditions, it's still true to call them humid.

teixeirak commented 3 years ago

Also, please clarify what you did with swr. The figure shows swr increased for both scenarios, but the SI currently states "For overstory drought PAR values, we used maximum Harvard NEON PAR value at 60m, and for understory drought PAR we used 50% increased PAR of understory normal value. "

NidhiVinod commented 3 years ago

Also, please clarify what you did with swr. The figure shows swr increased for both scenarios, but the SI currently states "For overstory drought PAR values, we used maximum Harvard NEON PAR value at 60m, and for understory drought PAR we used 50% increased PAR of understory normal value. "

For humid conditions, the overstory PAR value is the max mean, but for the drought scenario, the PAR value I used is the maximum recorded PAR for overstory which is 2302.15 (x 0.5 for SWR = 1151.075).

NidhiVinod commented 3 years ago

@NidhiVinod , I think it's better to refer to "humid" rather than "normal" conditions, especially because you used mean max humidity. Even if these parameters truly represent normal conditions, it's still true to call them humid.

@teixeirak, then maybe I need to change "normal" to "humid" in the figure as well right?

teixeirak commented 3 years ago

@teixeirak, then maybe I need to change "normal" to "humid" in the figure as well right?

Correct.

NidhiVinod commented 3 years ago

Okay, finished with this as well! But do you think I need make the font bigger in the tables as Eleinis suggested? The figure in the document is definitely shrunk to fit in there so the content might appear small, but I can adjust the font in the tables if needed!

teixeirak commented 3 years ago

I agree it's small, and so are the axis labels. The journal guidelines should give a minimum font size (when the figure is the size it will be on journal page). This isn't the sort of thing that would sink the paper in review, but you will need to fix it up. You should also adjust the symbols in this table to match what we use elsewhere. If it's hard to do this in R, you can always "cheat" and make the table manually.

NidhiVinod commented 3 years ago

I can close this right?, I uploaded a manual table with increased font size for axis labels and in the table!

teixeirak commented 3 years ago

Yes, I think this is good now.