search

EcoExtreML / Emulator

Apache License 2.0
0 stars 1 forks source link

Update environment #15

Closed fnattino closed 1 year ago

fnattino commented 1 year ago

Update the environment file for two reasons:

geek-yang commented 1 year ago
  • the RF model is saved in a pickle file. Reading the model fails if the version of scikit-learn in the environment does not match the version used to write the file. For now, I suggest to pin the version of scikit learn, but we should maybe find a better format to store the model.

Good point @fnattino ! I would propose ONNX (we also have an issue for it #6! The conversion is very simple and here is an example notebook. @QianqianHan96 we can look into it together.

QianqianHan96 commented 1 year ago

Update the environment file for two reasons:

  • the RF model is saved in a pickle file. Reading the model fails if the version of scikit-learn in the environment does not match the version used to write the file. For now, I suggest to pin the version of scikit learn, but we should maybe find a better format to store the model.
  • geopandas and shapely, used in the Europe notebook, are not part of the environment.

Thanks Francesco for updating the environment.yaml file.

QianqianHan96 commented 1 year ago
  • the RF model is saved in a pickle file. Reading the model fails if the version of scikit-learn in the environment does not match the version used to write the file. For now, I suggest to pin the version of scikit learn, but we should maybe find a better format to store the model.

Good point @fnattino ! I would propose ONNX (we also have an issue for it #6! The conversion is very simple and here is an example notebook. @QianqianHan96 we can look into it together.

Thanks Yang for your advice, I will have a look at this example notebook and then try to convert the pickle file. I will let you know if I meet problems.

geek-yang commented 1 year ago

Thanks Yang for your advice, I will have a look at this example notebook and then try to convert the pickle file. I will let you know if I meet problems.

Great! Keep me posted if you got any issue. We could also do it together @QianqianHan96 .

QianqianHan96 commented 1 year ago

Thanks Yang for your advice, I will have a look at this example notebook and then try to convert the pickle file. I will let you know if I meet problems.

Great! Keep me posted if you got any issue. We could also do it together @QianqianHan96 .

Thanks, Yang. I am wondering how could we do it together, in this pull request or create a new pull request?

geek-yang commented 1 year ago

Thanks Yang for your advice, I will have a look at this example notebook and then try to convert the pickle file. I will let you know if I meet problems.

Great! Keep me posted if you got any issue. We could also do it together @QianqianHan96 .

Thanks, Yang. I am wondering how could we do it together, in this pull request or create a new pull request?

Sorry for the late reply @QianqianHan96 . For ONNX let's do it in another PR, please review this PR first. We could take about it in our next sprint.

QianqianHan96 commented 1 year ago

Thanks Yang, I have reviewed this PR and merged it. I agree, let's discuss about the ONNX on 27 Oct.