Refactoring `calc_rssrbs.m`

EcoExtreML / STEMMUS_SCOPE

Integrated code of SCOPE and STEMMUS

GNU General Public License v3.0

14 stars 2 forks source link

Open BSchilperoort opened 1 year ago

BSchilperoort commented 1 year ago

The file calc_rssrbs.m has two problems:

There is no documentation. What does this function do?
It uses global variables. These should be changed to input arguments and passed to the function.

Additionally, it would be good to also rename the variables/structures according to the style guide where possible.

bobzsu commented 1 year ago

use 'SoilProperties' instead of 'global' in " global SaturatedMC ResidualMC fieldMC"

SaturatedMC not used. ResidualMC = SoilProperties.ResidualMC fieldMC = SoilProperties.ResidualMC

bobzsu commented 1 year ago

also add source/reference of equation, and meanings of constants 3.8, 4.1 and 4.3 (+reference, eq. no and explanation of constants)