EcoExtreML / STEMMUS_SCOPE

Integrated code of SCOPE and STEMMUS
GNU General Public License v3.0
14 stars 2 forks source link

Fix issue 181 #189

Closed SarahAlidoost closed 10 months ago

SarahAlidoost commented 1 year ago

Description

closes #181, the merge is pending addressing issues mentioned here. This branch re-produces the same results as those generated by the main branch, tested with a small dataset.

Checklist

SarahAlidoost commented 11 months ago

Looks good, nice work! I checked the model results and there seems to be no change at all between main and this branch.

It would be nice to have docstrings in many of the new functions though (what does the function do? what are the inputs? what's the source of the equations?). But I know you can't write those. Perhaps keeping track of the functions that still need a docstring in an issue could be a good idea?

thanks a lot for reviewing and running the code. I agree that the code needs more documentation, I submitted issue #191 for this.

SarahAlidoost commented 11 months ago

:heavy_exclamation_mark: :red_circle: Waiting for addressing issues mentioned here before the merge.