EcoExtreML / STEMMUS_SCOPE

Integrated code of SCOPE and STEMMUS
GNU General Public License v3.0
14 stars 2 forks source link

Fix issue 99 #194

Closed SarahAlidoost closed 9 months ago

SarahAlidoost commented 10 months ago

Description

closes #99

Checklist

This PR generates the same results as the main branch. Note that dryair.solveDryAirEquations runs only if Soilairefc == 1. However, the current value of Soilairefc is 0, see getModelSettings.m. Therefore, this part of the code hasn't been tested before, see #196. I fixed the bugs and now when Soilairefc==1 model runs and the refactored parts generate the same results as the old codes.

SarahAlidoost commented 9 months ago

Looks very good! No comments from me 😄

Did you run the branch-comparison notebook already for these changes? Or should I do that.

Thanks, yes I did it.