EcoExtreML / STEMMUS_SCOPE

Integrated code of SCOPE and STEMMUS
GNU General Public License v3.0
14 stars 6 forks source link

Make STEMMUS_SCOPE BMI-able #208

Closed BSchilperoort closed 9 months ago

BSchilperoort commented 10 months ago

Description

This PR will make STEMMUS_SCOPE compatible with a full BMI implemented in Python.

The documentation on this is still to-do (once PyStemmusScope has the BMI implemented https://github.com/EcoExtreML/STEMMUS_SCOPE_Processing/pull/89)

Checklist

BSchilperoort commented 10 months ago

@SarahAlidoost first local test of running the model's initialization, update and finalize steps separately seems to be successful! Thanks for the hard work of cleaning up the code and removing all globals :partying_face:

BSchilperoort commented 9 months ago

I've adressed all your comments @SarahAlidoost, and made some other changes I wanted to make.

You can now start the BMI mode without passing in a valid config:

./STEMMUS_SCOPE "" bmi

The config is then passed with initialize:

> Finished command. Select run mode: 
initialize "/path/to/cfg.txt"
SarahAlidoost commented 9 months ago

The config is then passed with initialize:

./STEMMUS_SCOPE "" initialize "/path/to/cfg.txt"

this command is not correct. It returns error:

Error using STEMMUS_SCOPE_exe
Too many input arguments.

MATLAB:TooManyInputs
BSchilperoort commented 9 months ago

Thanks for the review! I have committed your suggestions and addressed your comments.