EcoExtreML / STEMMUS_SCOPE

Integrated code of SCOPE and STEMMUS
GNU General Public License v3.0
14 stars 6 forks source link

Variable names and meaning #211

Closed MostafaGomaa93 closed 3 months ago

MostafaGomaa93 commented 9 months ago

Hi all,

Does anyone know the meaning of the "h", "hh" variables? The initial values of “h” and “hh” are set at lines 227->235 in the STEMMUS_SCOPE.m file

Thanks a lot in advance Mostafa

MostafaGomaa93 commented 9 months ago

got the answer from @yijianzeng by email

Both are for soil matric potential, the ‘hh’ is the one for the current time step, and ‘h’ is for the previous time step

MostafaGomaa93 commented 6 months ago

Hi @yijianzeng @Yunfei-Wang1993 @Crystal-szj @EntingTang I have spent some time going through the code, but it is a bit difficult to find what I need. Could anyone please help answer the following questions:

  1. The soil water conservation equation (equation A13 in the STEMMUS_SCOPE paper), where are the calcutions of this equation in the code?
  2. What are the symbols used in the code for the following variables (qLh, qLT, qLa, qvh, qvT, qva) of equation A13?
  3. What do those symbols mean: RHS, C4, and C4_a. They do exist in many functions, for e.g. in calculateBoundaryConditions?
  4. Why RHS is an output from different functions (e.g. solveSoilMoistureBalance, solveDryAirEquations, solveEnergyBalanceEquations, calculateBoundaryConditions, solveTridiagonalMatrixEquations) which confuses me

Thanks so much in advance

MostafaGomaa93 commented 6 months ago

@SarahAlidoost @BSchilperoort To highlight what I need (because I am stuck for a long time so far), my first two questions from my comment above are related to the STEMMUS_SCOPE & MODFLOW coupling. In brief, what MODFLOW needs from STEMMUS_SCOPE is the "recharge flux", which is Recharge = sum of (qLh, qLT, qLa, qvh, qvT, qva) at the soil layer where groundwater level exist I guess (need someone to confirm, mainly @yijianzeng) those variables are in the calculateEnergyParameters.m file in the following lines:

MostafaGomaa93 commented 6 months ago

Okay, i had a meeting with @yijianzeng which helps to answer my questions.

  • QL at line 63, which is most likely = qLh + qLT, confirm?

Yes

  • Qv at lines 70-72, which is most likely = qVh + qVT, confirm?

Yes

  • Qa at lines 64-66, which is most likely = qLa, confirm? still can't figure out where is then qva?

Currently in this version of the code so far (version 1.5) and also in previous versions, the airflow is neglected (see line 62) and then qa = 0 (line 64). However, the calcutions of qa is included (line 66), but so far not used. The main reason for neglecting qa is because its effect (based on tests from Yijian and Lianyu) was small and it needs extra computational and time to be solved. So in conclusion, the recharge flux that will be passed to MODFLOW will be of 4 components (qLh, qLT, qvh, qvT), only without (qLa and qva).

MostafaGomaa93 commented 6 months ago

Hi @yijianzeng Please could you explain to me the CalculateSoilwaterFlux function and its outputs? what are SAVE, QMT and QMB?

I am asking because I can see in STEMMUS_MODFLOW -> in the HYDRUS1RECHARGE function (line 12): that the Qs (which is cumulative water flux out of the moving boundary, based on Lianyu variables definition) is based on TQL (line 236 in the MainLoop11). TQL is calculated in the Diff_Moisture_Heat function based on QMT at lines 341-343. QMT is calculated in line 314. So at the end Qs is based on QMT