EcoExtreML / STEMMUS_SCOPE

Integrated code of SCOPE and STEMMUS
GNU General Public License v3.0
14 stars 2 forks source link

How to set boundary conditions? Only from the source code? #213

Closed MostafaGomaa93 closed 4 days ago

MostafaGomaa93 commented 6 months ago

Hi @SarahAlidoost, @BSchilperoort and @yijianzeng

Is the only way to set the boundary conditions (e.g. NBChB = 1 or 2 or 3) through changing the value inside the source code? or that could be done from outside (e.g. from a text file).

If I talk about STEMMUS_SCOPE_MODFLOW -> NBChB must be 1 always ( I see that default value is 3 in this line).

Also, if there is groundwater temperature data available -> NBCTB will be also = 1

SarahAlidoost commented 6 months ago

Is the only way to set the boundary conditions (e.g. NBChB = 1 or 2 or 3) through changing the value inside the source code? or that could be done from outside (e.g. from a text file).

Currently no. The variable NBChB is set only in one script setBoundaryCondition.m. If it is defined in a file such as the config file, it can be set from outside. In your case, if NBChB is always 1, then it can be set internally. There is also a file getModelSettings.m. that contains some settings. It would be nice if eventually the content of this file is moved to the config file. But please note that some of those settings have not been tested, see #196

MostafaGomaa93 commented 6 months ago

I would agree with @SarahAlidoost to move some of the content of both the setBoundaryCondtion.m and getModelSettings.m to the config file. It will be easier for the users later to change the settings based on their applications. That will also be helpful to generate a new exe with changing these settings from the config file and be latter used with the BMI (without the need to generate a new exe for each time we want to change the model settings). what do you think @yijianzeng?

Lianyu-Yu commented 6 months ago

For STEMMUS-MODFLOW, all the STEMMUS settings are in the file STEMMUS_config.m, which is the combination of the original files 'Constants.m' and 'StartInit.m'.